Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9954

u_masspm* permissions are forced to never for certain groups

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.3, 3.0.4, 3.0.5, 3.0.6, 3.0.7, 3.0.7-PL1, 3.0.8-RC1, 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Authentication
    • Labels:
      None

      Description

      The ROLE_USER_NOAVATAR is given a never permission for the for the two u_masspm* permissions. It makes however more sense to assign a no so that this role doesn't remove this functionality as there isn't a reason for these rolls to get never assigned. The default never is assigned to ROLE_USER_NOPM and thats the only role that should assign never to pm permissions (out of the box)

        Activity

        Hide
        Erik Frèrejean Erik Frèrejean added a comment -

        Seems that the ROLE_USER_LIMITED does it correctly.

        Show
        Erik Frèrejean Erik Frèrejean added a comment - Seems that the ROLE_USER_LIMITED does it correctly.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Should existing boards also be adjusted?

        Show
        Oleg Oleg [X] (Inactive) added a comment - Should existing boards also be adjusted?
        Hide
        Erik Frèrejean Erik Frèrejean added a comment -

        I'm not entirely sure whether we should adjust it for existing boards using this role. On one hand it does correct unexpected behavior but on the other it might confuse administrators using this role as it suddenly starts to act different.
        I personally wouldn't adjust it for existing boards as I can't recall any users complaining about this so adjusting it without notifying might actually cause more issues than that it will resolve. But I leave this one up to the devs, if you guys feel that the updater needs to account for this change let me know and I'll update the patch .

        Show
        Erik Frèrejean Erik Frèrejean added a comment - I'm not entirely sure whether we should adjust it for existing boards using this role. On one hand it does correct unexpected behavior but on the other it might confuse administrators using this role as it suddenly starts to act different. I personally wouldn't adjust it for existing boards as I can't recall any users complaining about this so adjusting it without notifying might actually cause more issues than that it will resolve. But I leave this one up to the devs, if you guys feel that the updater needs to account for this change let me know and I'll update the patch .
        Hide
        nickvergessen Joas Schilling added a comment -

        I think we can not edit existing permissions. As we don't know whether the admin had a look at them and they were set to never.

        Show
        nickvergessen Joas Schilling added a comment - I think we can not edit existing permissions. As we don't know whether the admin had a look at them and they were set to never.
        Hide
        Erik Frèrejean Erik Frèrejean added a comment -

        Added pull request

        Show
        Erik Frèrejean Erik Frèrejean added a comment - Added pull request

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Erik Frèrejean Erik Frèrejean
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development