Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9946

$inserts empty in sql_query() for oracle

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Labels:
      None
    • Environment:
      Any using oracle db.

      Description

      http://www.phpbb.com/bugs/modteamtools/62554
      Look at the attached image, "invalid argument supplied for foreach()".
      From includes/db/oracle.php starting at line 327.

      $inserts = $vals[0];
      unset($vals);
       
      foreach ($inserts as $key => $value)
      {

      But the part where $vals is set is commented out making $inserts to be empty.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Can anyone supply the steps needed to reproduce this issue?

          Show
          Oleg Oleg [X] (Inactive) added a comment - Can anyone supply the steps needed to reproduce this issue?
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Patch looks pretty reasonable. OK to merge?

          Show
          Oleg Oleg [X] (Inactive) added a comment - Patch looks pretty reasonable. OK to merge?
          Hide
          igorw Igor Wiedler [X] (Inactive) added a comment -

          Can someone else (Jari?) test it? Maybe we can have a test case for this?

          Show
          igorw Igor Wiedler [X] (Inactive) added a comment - Can someone else (Jari?) test it? Maybe we can have a test case for this?
          Hide
          Noxwizard Patrick Webster added a comment -

          I can confirm that it does fix posting for text with more than 4k characters.

          Show
          Noxwizard Patrick Webster added a comment - I can confirm that it does fix posting for text with more than 4k characters.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              tumba25 Jari Kanerva
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development