Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9937

Feed Icon displays on Forum links

          Details

          • Type: Improvement
          • Status: Unverified Fix
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.0.8
          • Fix Version/s: 3.0.9-RC1
          • Component/s: Viewing forums
          • Labels:
            None

            Description

            The feed icon will display on External links when viewing a forum that has the link set in the ACP to display the icon. While it is not possible to select a link type forum to display the icon, it also isn't possible to select it to not display the icon.

            I believe this is an issue when an admin updates their board.

              Issue Links

              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-10034 Feed for link forum

              • Trivial - Cosmetic problem like misspelt words or misaligned text.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                marc1706 marc1706 added a comment -

                You can reproduce this by doing the following:
                1. Create a forum and enable feeds for that forum.
                2. Change that forum to a link.

                Now you can't change the settings of the Feed for this Link.

                Maybe we should add some kind of code that removes forums that are changed from a forum to a link. I think that would be the easiest way.

                Show
                marc1706 marc1706 added a comment - You can reproduce this by doing the following: 1. Create a forum and enable feeds for that forum. 2. Change that forum to a link. Now you can't change the settings of the Feed for this Link. Maybe we should add some kind of code that removes forums that are changed from a forum to a link. I think that would be the easiest way.
                Hide
                Permalink
                bantu Andreas Fischer added a comment -

                With "the feed icon" you mean this?

                <!-- IF S_ENABLE_FEEDS and forumrow.S_FEED_ENABLED --><!-- <a class="feed-icon-forum" title="{L_FEED} - {forumrow.FORUM_NAME}" href="{U_FEED}?f={forumrow.FORUM_ID}"><img src="{T_THEME_PATH}/images/feed.gif" alt="{L_FEED} - {forumrow.FORUM_NAME}" /></a> --><!-- ENDIF -->

                Show
                bantu Andreas Fischer added a comment - With "the feed icon" you mean this? <!-- IF S_ENABLE_FEEDS and forumrow.S_FEED_ENABLED --><!-- <a class="feed-icon-forum" title="{L_FEED} - {forumrow.FORUM_NAME}" href="{U_FEED}?f={forumrow.FORUM_ID}"><img src="{T_THEME_PATH}/images/feed.gif" alt="{L_FEED} - {forumrow.FORUM_NAME}" /></a> --><!-- ENDIF -->
                Hide
                Permalink
                marc1706 marc1706 added a comment -

                Yes, that icon.

                Show
                marc1706 marc1706 added a comment - Yes, that icon.
                Hide
                Permalink
                RMcGirr83 Rich McGirr added a comment -

                https://github.com/RMcGirr83/phpbb3/commit/f9392070c5dca1c4ad5b4b6a269c176bfde5283f

                Show
                RMcGirr83 Rich McGirr added a comment - https://github.com/RMcGirr83/phpbb3/commit/f9392070c5dca1c4ad5b4b6a269c176bfde5283f

                  People

                  • Assignee:
                    igorw Igor Wiedler [X] (Inactive)
                    Reporter:
                    RMcGirr83 Rich McGirr
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development