Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9911

Incorrect open/close field in Manage ranks ACP

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: ACP
    • Labels:
      None

      Description

      Bug exists only in IE (I tested on IE8):
      Go to ACP -> Manage ranks, press "Edit" on any rank and switch "Set as special rank" to "No". Field "Minimum posts:" does not open... Then press "Yes" and field is open. It should be reversed.

        Issue Links

          Activity

          Hide
          marc1706 marc1706 added a comment - - edited

          And now the funny part:
          Click on No and then click somewhere else on the page --> Minimum posts is shown
          Click on Yes and then click somewhere else on the page --> Minimum posts is hidden

          Edit:
          What I mean is that this is a issue with IE's javascript engine and I'm not quite sure how that could be fixed.

          Show
          marc1706 marc1706 added a comment - - edited And now the funny part: Click on No and then click somewhere else on the page --> Minimum posts is shown Click on Yes and then click somewhere else on the page --> Minimum posts is hidden Edit: What I mean is that this is a issue with IE's javascript engine and I'm not quite sure how that could be fixed.
          Hide
          nickvergessen Joas Schilling added a comment -

          It can be easily fixed, by changing onchange to onclick
          Tested on IE8, Safari 5, Opera 11 and Firefox 3.6

          As we do not use toogle [0] but hide [-1] and show [1] on dE() here, it also works correctly for clicking multiple times on one option.

          Show
          nickvergessen Joas Schilling added a comment - It can be easily fixed, by changing onchange to onclick Tested on IE8, Safari 5, Opera 11 and Firefox 3.6 As we do not use toogle [0] but hide [-1] and show [1] on dE() here, it also works correctly for clicking multiple times on one option.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Firefox seems to behave identically with and without the patch.

          Show
          Oleg Oleg [X] (Inactive) added a comment - Firefox seems to behave identically with and without the patch.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Tested on ie6

          Show
          Oleg Oleg [X] (Inactive) added a comment - Tested on ie6

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Shredder Shredder
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development