Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9899

Change the style in the ACP for the recaptcha to match that displayed on prosilver

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.8-RC1
    • Fix Version/s: 3.0.8
    • Component/s: None
    • Labels:
      None

      Description

      In 3.0.8-RC1 the styling of the reCaptcha changed, this should be reflected as well within the ACP.

        Issue Links

          Activity

          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          See my comment on why I deliberately did not style the general ACP view here:
          http://tracker.phpbb.com/browse/PHPBB3-9853?focusedCommentId=34989&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_34989

          As for making it match prosilver, what happens if the board doesn't have either PS or SS2 installed? I know I deleted them and I have found several users in support who also delete unused styles. What if they have edited PS and changed the colors as well as the recaptcha theme in the template, as they are freely able to do? Now it still doesn't match anything. The ACP view is not there to reflect the specific recaptcha theme(s) that are used in whatever board styles you have set, but simply to show that it is working.

          Show
          narqelion narqelion [X] (Inactive) added a comment - See my comment on why I deliberately did not style the general ACP view here: http://tracker.phpbb.com/browse/PHPBB3-9853?focusedCommentId=34989&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_34989 As for making it match prosilver, what happens if the board doesn't have either PS or SS2 installed? I know I deleted them and I have found several users in support who also delete unused styles. What if they have edited PS and changed the colors as well as the recaptcha theme in the template, as they are freely able to do? Now it still doesn't match anything. The ACP view is not there to reflect the specific recaptcha theme(s) that are used in whatever board styles you have set, but simply to show that it is working.
          Hide
          RMcGirr83 Rich McGirr added a comment -

          "What if they have edited PS and changed the colors as well as the recaptcha theme in the template, as they are freely able to do?"

          Then they can also freely change it in the ACP as well. If they are smart enough to be able to theme it for a style, then they most certainly are smart enough to make it in the ACP whatever theme they like as well.

          To me, change the theme to match in PS and SS is minutia anyway.

          Show
          RMcGirr83 Rich McGirr added a comment - "What if they have edited PS and changed the colors as well as the recaptcha theme in the template, as they are freely able to do?" Then they can also freely change it in the ACP as well. If they are smart enough to be able to theme it for a style, then they most certainly are smart enough to make it in the ACP whatever theme they like as well. To me, change the theme to match in PS and SS is minutia anyway.
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          Then they can also freely change it in the ACP as well. If they are smart enough to be able to theme it for a style, then they most certainly are smart enough to make it in the ACP whatever theme they like as well.

          No actually they cannot. As I said, currently the ACP has no feature to apply styles, or for the ACP templates to be edited from within the ACP -> Styles -> Templates UI as the real board Styles do. What you are suggesting is that the ACP needs to be themed to match a particular style and that doesn't really make sense with the variability of available styles and recaptcha themes a board could have installed. The purpose of the recaptcha or any captcha display within the ACP interface is to verify it's functionality, not to accurately portray how it will look to users of the board in any given form it is applied to since each style can use a different recaptcha theme. The ACP as it stands today, does not match the look and feel of either Prosilver or Subsilver2, so why would the ACP recaptcha plugin need to match one defined in a style template to coordinate with a particular styles colors? "Red" is the default recaptcha theme so when you are selecting the plugin within the ACP why would you not expect to see the theme Google has chosen to be their default? If it were a 1:1 relationship and only one recaptcha theme could be defined per board I could see wanting them to match but each style can define a different theme so what is the value in having the ACP "match" only one of multiple potential recaptcha themes being used on a board?

          Show
          narqelion narqelion [X] (Inactive) added a comment - Then they can also freely change it in the ACP as well. If they are smart enough to be able to theme it for a style, then they most certainly are smart enough to make it in the ACP whatever theme they like as well. No actually they cannot. As I said, currently the ACP has no feature to apply styles, or for the ACP templates to be edited from within the ACP -> Styles -> Templates UI as the real board Styles do. What you are suggesting is that the ACP needs to be themed to match a particular style and that doesn't really make sense with the variability of available styles and recaptcha themes a board could have installed. The purpose of the recaptcha or any captcha display within the ACP interface is to verify it's functionality, not to accurately portray how it will look to users of the board in any given form it is applied to since each style can use a different recaptcha theme. The ACP as it stands today, does not match the look and feel of either Prosilver or Subsilver2, so why would the ACP recaptcha plugin need to match one defined in a style template to coordinate with a particular styles colors? "Red" is the default recaptcha theme so when you are selecting the plugin within the ACP why would you not expect to see the theme Google has chosen to be their default? If it were a 1:1 relationship and only one recaptcha theme could be defined per board I could see wanting them to match but each style can define a different theme so what is the value in having the ACP "match" only one of multiple potential recaptcha themes being used on a board?
          Hide
          bantu Andreas Fischer added a comment - - edited

          Ok all right, as you pointed out we cannot match a specific style. I'll suggest to change it to the clean version because that fits the ACP better.

          Show
          bantu Andreas Fischer added a comment - - edited Ok all right, as you pointed out we cannot match a specific style. I'll suggest to change it to the clean version because that fits the ACP better.
          Hide
          naderman Nils Adermann added a comment -

          I cannot possibly understand how one can write novel-length comments in response to such a trivial problem. It is obvious that no perfect solution can be found here easily. So the best currently available option is to style recaptcha in the ACP like in prosilver. It fits better in the ACP and by default it shows exactly what it'll look like. For all other cases we don't have a solution anyway.

          Show
          naderman Nils Adermann added a comment - I cannot possibly understand how one can write novel-length comments in response to such a trivial problem. It is obvious that no perfect solution can be found here easily. So the best currently available option is to style recaptcha in the ACP like in prosilver. It fits better in the ACP and by default it shows exactly what it'll look like. For all other cases we don't have a solution anyway.
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          When I proposed changing the recaptcha theme in both Prosilver and Subsilver it was motivated by an actual usability issue I saw in the support forums. Users who were using either of the two default styles and recaptcha as their CAPTCHA plugin were forced to edit the default styles themselves and they should not have to. That was the value gained from changing the style templates. There is almost zero value to be gained by changing the display in the ACP (afaik nobody has ever been confused by, asked how to change or needed the ACP recaptcha theme changed from its default,) in fact it would no longer be representative of the default recaptcha, since the default is "Red". Because recaptcha themes are style dependent the ACP can never accurately portray what they will look like for all cases (boards) or even a majority of cases and when you don't have a solution for the majority of cases you don't have a solution at all. The best currently available option was to leave the ACP alone, as the changes to the two packaged styles really had no connection with how and why the recaptcha is displayed there. Which is why my patch specifically left it untouched. Contrary to popular belief here, being able to see the forest for the trees is actually something to aspire to.

          Rich's comment that "In 3.0.8-RC1 the styling of the reCaptcha changed, this should be reflected as well within the ACP." shows he did not understand my motivation and the value gained, which was completely style based, not board based. You want to make a frivolous cosmetic change in the ACP that benefits no one really, that is fine just don't try to tie the change to my patch as justification when they are completely unrelated.

          Show
          narqelion narqelion [X] (Inactive) added a comment - When I proposed changing the recaptcha theme in both Prosilver and Subsilver it was motivated by an actual usability issue I saw in the support forums. Users who were using either of the two default styles and recaptcha as their CAPTCHA plugin were forced to edit the default styles themselves and they should not have to. That was the value gained from changing the style templates. There is almost zero value to be gained by changing the display in the ACP (afaik nobody has ever been confused by, asked how to change or needed the ACP recaptcha theme changed from its default,) in fact it would no longer be representative of the default recaptcha, since the default is "Red". Because recaptcha themes are style dependent the ACP can never accurately portray what they will look like for all cases (boards) or even a majority of cases and when you don't have a solution for the majority of cases you don't have a solution at all. The best currently available option was to leave the ACP alone, as the changes to the two packaged styles really had no connection with how and why the recaptcha is displayed there. Which is why my patch specifically left it untouched. Contrary to popular belief here, being able to see the forest for the trees is actually something to aspire to. Rich's comment that "In 3.0.8-RC1 the styling of the reCaptcha changed, this should be reflected as well within the ACP." shows he did not understand my motivation and the value gained, which was completely style based, not board based. You want to make a frivolous cosmetic change in the ACP that benefits no one really, that is fine just don't try to tie the change to my patch as justification when they are completely unrelated.
          Hide
          naderman Nils Adermann added a comment -

          I didn't even read that. If you're unable to express your point more concisely I guess it's just not very convincing one.

          Show
          naderman Nils Adermann added a comment - I didn't even read that. If you're unable to express your point more concisely I guess it's just not very convincing one.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              RMcGirr83 Rich McGirr
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development