Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.8-RC1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: None
    • Labels:
      None

      Description

      PHPBB3-9061 introduced a fix for rare race conditions with the email queue, it would appear that the fix has caused massive email backlogs. I'm recommending this fix is reverted and the issue reopened and fixed properly in 3.0.9.

        Issue Links

          Activity

          Hide
          ToonArmy Chris Smith added a comment - - edited

          phpBB.com was updated on the 31st Oct. the issue appeared within the next 24 hours as evidenced by the following:

          Before

          Date: Thu, 28 Oct 2010 20:22:52 +0000
          Received: by www.phpbb.com (Postfix, from userid 81)
          	id 1AB3CC82DB; Thu, 28 Oct 2010 20:23:45 +0000 (UTC)
          

          After

          Date: Mon, 01 Nov 2010 14:31:16 +0000
          Received: by www.phpbb.com (Postfix, from userid 81)
          	id B83B9C81E4; Mon,  1 Nov 2010 17:56:26 +0000 (UTC)
          

          Show
          ToonArmy Chris Smith added a comment - - edited phpBB.com was updated on the 31st Oct. the issue appeared within the next 24 hours as evidenced by the following: Before Date: Thu, 28 Oct 2010 20:22:52 +0000 Received: by www.phpbb.com (Postfix, from userid 81) id 1AB3CC82DB; Thu, 28 Oct 2010 20:23:45 +0000 (UTC) After Date: Mon, 01 Nov 2010 14:31:16 +0000 Received: by www.phpbb.com (Postfix, from userid 81) id B83B9C81E4; Mon, 1 Nov 2010 17:56:26 +0000 (UTC)
          Hide
          ToonArmy Chris Smith added a comment -

          The issue seems to be resolved by decreasing the queue_interval to 60s and adjusting the package size to suit the board.

          Show
          ToonArmy Chris Smith added a comment - The issue seems to be resolved by decreasing the queue_interval to 60s and adjusting the package size to suit the board.
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          Did anybody do the math here? You realize you quadrupled the amount of emails boards will attempt to send per hour for boards using the queue right? Guess how many phpBB boards are installed in hosting environments that will support that volume? Sure you are only changing the values if they were set at the previous defaults, but those same boards who never needed to tweak those values are the same boards the new values will cause problems for where the old defaults didn't.

          Chris was correct in his initial assessment, the patch that caused the regression that requires yet another patch, should have been reverted until more thorough testing could have been done to provide a solution that doesn't have a negative impact on more boards than the original patch was even targeted to fix.

          Show
          narqelion narqelion [X] (Inactive) added a comment - Did anybody do the math here? You realize you quadrupled the amount of emails boards will attempt to send per hour for boards using the queue right? Guess how many phpBB boards are installed in hosting environments that will support that volume? Sure you are only changing the values if they were set at the previous defaults, but those same boards who never needed to tweak those values are the same boards the new values will cause problems for where the old defaults didn't. Chris was correct in his initial assessment, the patch that caused the regression that requires yet another patch, should have been reverted until more thorough testing could have been done to provide a solution that doesn't have a negative impact on more boards than the original patch was even targeted to fix.
          Hide
          naderman Nils Adermann added a comment -

          The 3.0.7 and earlier state would have sent out way more emails than even the new values, simply because it totally failed to correctly enforce the package_size so I don't see any problem here.

          Show
          naderman Nils Adermann added a comment - The 3.0.7 and earlier state would have sent out way more emails than even the new values, simply because it totally failed to correctly enforce the package_size so I don't see any problem here.
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          Both your comments above are incorrect, which is why you do not see the problem here. Not to worry though, I already have a patch to revert the above change (as well as the original change that introduced the regression in the first place) and am making it available to phpBB users myself.

          Show
          narqelion narqelion [X] (Inactive) added a comment - Both your comments above are incorrect, which is why you do not see the problem here. Not to worry though, I already have a patch to revert the above change (as well as the original change that introduced the regression in the first place) and am making it available to phpBB users myself.
          Hide
          brunoais brunoais added a comment -

          E-mail queue seems to be working properly.

          Show
          brunoais brunoais added a comment - E-mail queue seems to be working properly.

            People

            • Assignee:
              igorw Igor Wiedler [X] (Inactive)
              Reporter:
              ToonArmy Chris Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development