Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9878

Get rid of Internet Explorer 7 emulation

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.9-RC1
    • Component/s: None
    • Labels:
      None
    1. ie8.css
      0.4 kB
      Mungo [X]
    2. textarea_conditional.patch
      2 kB
      Mungo [X]
    3. textarea.patch
      4 kB
      Mungo [X]

      Issue Links

        Activity

        Hide
        ChrisTX ChrisTX [X] (Inactive) added a comment -

        EmulateIE9 is not a valid X-UA-Compatible flag. Moreover there can only be one X-UA-Compatible flag at all. ( http://msdn.microsoft.com/en-us/library/cc288325(v=VS.85).aspx ). The EmulateIE7 mode was introduced for a special reason, that is to allow sites with mixed Quirks mode (IE5 stds) and newer (IE7 stds) to work properly. It will use the normal IE document mode compatibility methods to determine what mode to apply and then use either Quirks or IE7 standards.

        However, what is wanted here is neither. Instead I would suggest a change to the following header:

        <!--[if IE 8]>
        <meta http-equiv="X-UA-Compatible" content="IE=7">
        <![endif]-->

        Like that it will only affect IE 8 (which is affected) and will also use the intended IE7 standards without having to decide any further there.

        Show
        ChrisTX ChrisTX [X] (Inactive) added a comment - EmulateIE9 is not a valid X-UA-Compatible flag. Moreover there can only be one X-UA-Compatible flag at all. ( http://msdn.microsoft.com/en-us/library/cc288325(v=VS.85).aspx ). The EmulateIE7 mode was introduced for a special reason, that is to allow sites with mixed Quirks mode (IE5 stds) and newer (IE7 stds) to work properly. It will use the normal IE document mode compatibility methods to determine what mode to apply and then use either Quirks or IE7 standards. However, what is wanted here is neither. Instead I would suggest a change to the following header: <!-- [if IE 8] > <meta http-equiv="X-UA-Compatible" content="IE=7"> <! [endif] --> Like that it will only affect IE 8 (which is affected) and will also use the intended IE7 standards without having to decide any further there.
        Hide
        thinkagain thinkagain [X] (Inactive) added a comment -

        "ChrisTX added a comment - 03/Jan/11 8:09 PM EmulateIE9 is not a valid X-UA-Compatible flag. Moreover there can only be one X-UA-Compatible flag at all. "
        Wrong and wrong. You have not read the ticket this was linked to or you would already know that.

        Ftr, this ticket is bogus as you cannot get rid of the emulation without replacing it with a CSS hack instead, six of one half dozen of another. Of the two evils, document mode is the most acceptable even to M$.

        Show
        thinkagain thinkagain [X] (Inactive) added a comment - "ChrisTX added a comment - 03/Jan/11 8:09 PM EmulateIE9 is not a valid X-UA-Compatible flag. Moreover there can only be one X-UA-Compatible flag at all. " Wrong and wrong. You have not read the ticket this was linked to or you would already know that. Ftr, this ticket is bogus as you cannot get rid of the emulation without replacing it with a CSS hack instead, six of one half dozen of another. Of the two evils, document mode is the most acceptable even to M$.
        Hide
        bantu Andreas Fischer added a comment -

        thinkagain: The stuff said on http://www.ozzu.com/website-design-forum/ie8-textarea-scrolling-bug-t99866.html doesn't really qualify as a hack in my opinion. And as far as I know the textarea is the only reason why emulation is on.

        Show
        bantu Andreas Fischer added a comment - thinkagain: The stuff said on http://www.ozzu.com/website-design-forum/ie8-textarea-scrolling-bug-t99866.html doesn't really qualify as a hack in my opinion. And as far as I know the textarea is the only reason why emulation is on.
        Hide
        thinkagain thinkagain [X] (Inactive) added a comment -

        Andreas Fischer: Did you even read the comments you link to? "This bug can be fixed by activating compatibility view, or it can also be fixed by implementing a CSS hack which is now done on ozzu." Any browser specific CSS code designed to mask a browser bug is a CSS hack, your opinion not withstanding. http://www.digital-web.com/articles/keep_css_simple/

        Show
        thinkagain thinkagain [X] (Inactive) added a comment - Andreas Fischer: Did you even read the comments you link to? "This bug can be fixed by activating compatibility view, or it can also be fixed by implementing a CSS hack which is now done on ozzu." Any browser specific CSS code designed to mask a browser bug is a CSS hack, your opinion not withstanding. http://www.digital-web.com/articles/keep_css_simple/
        Hide
        Mungo Mungo [X] (Inactive) added a comment -

        variant 1: textarea.patch

        variant 2: textarea_conditional.patch + ie8.css

        Show
        Mungo Mungo [X] (Inactive) added a comment - variant 1: textarea.patch variant 2: textarea_conditional.patch + ie8.css
        Hide
        updown updown [X] (Inactive) added a comment -

        Conditional Statements do NOT work with META-Tags! Also, the current phpBB-solution does NOT work correctly with IE9Beta.

        The ONLY solution that does work right now is comma-separated : IE=7, IE=9

        http://emological.com/ie/

        Show
        updown updown [X] (Inactive) added a comment - Conditional Statements do NOT work with META-Tags! Also, the current phpBB-solution does NOT work correctly with IE9Beta. The ONLY solution that does work right now is comma-separated : IE=7, IE=9 http://emological.com/ie/
        Hide
        naderman Nils Adermann added a comment -

        So I tried this in IE7, IE8 and IE9. The original bug (textarea scrolling up while typing) does not exist in any one of them with the current code. I don't see the point of any of these patches given that it appears to be working fine?

        Show
        naderman Nils Adermann added a comment - So I tried this in IE7, IE8 and IE9. The original bug (textarea scrolling up while typing) does not exist in any one of them with the current code. I don't see the point of any of these patches given that it appears to be working fine?
        Hide
        AdamR Adam Reyher added a comment -

        Submitted proposed patch. The advantage to this patch is that there are no conditional statements in the markup for IE nor any additional files. The downside is that IE6 is "broken." It will use the static width at all times. Per discussion with Nils, IE6 support is not much of a concern, anymore.

        Show
        AdamR Adam Reyher added a comment - Submitted proposed patch. The advantage to this patch is that there are no conditional statements in the markup for IE nor any additional files. The downside is that IE6 is "broken." It will use the static width at all times. Per discussion with Nils, IE6 support is not much of a concern, anymore.

          People

          • Assignee:
            naderman Nils Adermann
            Reporter:
            bantu Andreas Fischer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development