Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9876

Names and descriptions for roles "Newly registered User" in "User roles" and "Forum roles" must be different

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Language pack
    • Labels:
      None

      Description

      What I suggest?


      1. ACP -> PERMISSIONS -> PERMISSION ROLES -> User roles
        For user based role "Newly registered User" and it description
        • New Title:

          New Users with no private messages and attachments

        • New Description:

          A user based role for members of the special newly registered users group; contains NEVER permissions to lock private messages and attachments for new users.

      2. ACP -> PERMISSIONS -> PERMISSION ROLES -> Forum roles
        For forum based role "Newly registered User" and it description
        • New Title:

          New Users with post approval

        • New Description:

          A forum based role for members of the special newly registered users group; contains NEVER permissions not allowing post to appear without approval


      Why I suggest?


      I referring to these changes because there is a mess for new phpBB administrators after their first forum's install.

      It is not clear for them:

      • when they go to ACP -> PERMISSIONS -> GLOBAL PERMISSIONS -> Groups' permissions
      • select Newly registered user group
      • see there the option Role: with the name Newly registered User
      • that this role is from PERMISSION ROLES -> User roles and not from PERMISSION ROLES -> Forum roles
        • the same for ACP -> PERMISSIONS -> GLOBAL PERMISSIONS -> Users' permissions

      And in the opposite direction it is not clear for them:

      • when they go to ACP -> FORUM BASED PERMISSIONS -> FORUM PERMISSIONS -> Groups' forum permissions
      • select in Look up usergroup: the Newly registered users group
      • select some forum
      • see there the option Role: with the name Newly registered User
      • that this role is from PERMISSION ROLES -> User roles and not from PERMISSION ROLES -> Forum roles
        • the same for ACP -> FORUM BASED PERMISSIONS -> FORUM PERMISSIONS -> Users' forum permissions
        • the same for ACP -> FORUM BASED PERMISSIONS -> FORUM PERMISSIONS -> Forum permissions

      Where to look?


      1. ACP -> PERMISSIONS -> PERMISSION ROLES -> User roles
        • Name and description for role Newly registered User
        • In language files it is code:

          language/en/acp/permissions.php - line 184

          'ROLE_USER_NEW_MEMBER'          => 'Newly registered User',
          

          language/en/acp/permissions.php - line 210

          'ROLE_DESCRIPTION_USER_NEW_MEMBER'              => 'A role for members of the special newly registered users group; contains <samp>NEVER</samp> permissions to lock features for new users.',
          

      1. ACP -> PERMISSIONS -> PERMISSION ROLES -> Forum roles
        • Name and description for role Newly registered User
        • In language files it is code:

          language/en/acp/permissions.php - line 174

          'ROLE_FORUM_NEW_MEMBER'         => 'Newly registered User',
          

          language/en/acp/permissions.php - line 200

          'ROLE_DESCRIPTION_FORUM_NEW_MEMBER'             => 'A role for members of the special newly registered users group; contains <samp>NEVER</samp> permissions to lock features for new users.',
          


      How fix will look like?


      1. ACP -> PERMISSIONS -> PERMISSION ROLES -> User roles
        • language/en/acp/permissions.php - line 184

          'ROLE_USER_NEW_MEMBER'          => 'New Users with no private messages and attachments',
          

          language/en/acp/permissions.php - line 210

          'ROLE_DESCRIPTION_USER_NEW_MEMBER'              => 'A user based role for members of the special newly registered users group; contains <samp>NEVER</samp> permissions to lock private messages and attachments for new users.',
          

      1. ACP -> PERMISSIONS -> PERMISSION ROLES -> Forum roles
        • language/en/acp/permissions.php - line 174

          'ROLE_FORUM_NEW_MEMBER'         => 'New Users with post approval',
          

          language/en/acp/permissions.php - line 200

          'ROLE_DESCRIPTION_FORUM_NEW_MEMBER'             => 'A forum based role for members of the special newly registered users group; contains <samp>NEVER</samp> contains NEVER permissions not allowing post to appear without approval for new users.',
          

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Has inline patch.

        Show
        bantu Andreas Fischer added a comment - Has inline patch.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Not reviewed.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Not reviewed.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        The problem with the original suggested wording is that, while it is true for default roles, admins can customize the roles to have different permissions.

        My version makes the role names distinct by appending "access" and "features" as appropriate.

        Show
        Oleg Oleg [X] (Inactive) added a comment - The problem with the original suggested wording is that, while it is true for default roles, admins can customize the roles to have different permissions. My version makes the role names distinct by appending "access" and "features" as appropriate.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Makc666 Makc666 [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development