Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9853

Change default reCAPTCHA theme in Prosilver & Subsilver2 to better coordinate with style color scheme

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Styles
    • Labels:
      None
    • Environment:
      n/a

      Description

      As you know the default reCAPTCHA API theme is red, which does not coordinate with the color scheme of Prosilver or Subsilver2, the default styles packaged with phpBB3. Many people who use either of these two styles and the reCAPTCHA wish to change the reCAPTCHA colors to match the style. It would be better if they were cohesive to start with. I propose changing the reCAPTCHA theme for both styles to "clean" which is much more aesthetically pleasing than the default today. See images below:

      Prosilver would go from this:

      to this:

      and Subsilver2 would go from this:

      to this:

      I believe the images demonstrate how jarringly out of place the default reCAPTCHA red theme is with both of the included package styles.

      1. 9853.diff
        1.0 kB
        narqelion [X]

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          I think it would be a good idea to change it. If you have a patch, it might be possible to get it into 3.0.8-RC1, otherwise it'll probably be 3.0.9-RC1

          Show
          bantu Andreas Fischer added a comment - I think it would be a good idea to change it. If you have a patch, it might be possible to get it into 3.0.8-RC1, otherwise it'll probably be 3.0.9-RC1
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          If you have a patch, it might be possible to get it into 3.0.8-RC1, otherwise it'll probably be 3.0.9-RC1

          The only thing I could give you would be an SVN diff, which I don't think you can use anymore, sorry.

          Show
          narqelion narqelion [X] (Inactive) added a comment - If you have a patch, it might be possible to get it into 3.0.8-RC1, otherwise it'll probably be 3.0.9-RC1 The only thing I could give you would be an SVN diff, which I don't think you can use anymore, sorry.
          Hide
          A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

          An SVN diff would be perfectly fine.

          Show
          A_Jelly_Doughnut A_Jelly_Doughnut added a comment - An SVN diff would be perfectly fine.
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          Well here's an SVN diff then.

          Show
          narqelion narqelion [X] (Inactive) added a comment - Well here's an SVN diff then.
          Hide
          bantu Andreas Fischer added a comment -

          Show
          bantu Andreas Fischer added a comment -
          Hide
          RMcGirr83 Rich McGirr added a comment -

          Verified as fixed

          Show
          RMcGirr83 Rich McGirr added a comment - Verified as fixed
          Hide
          RMcGirr83 Rich McGirr added a comment -

          Though in the ACP it still displays the red coloring

          Show
          RMcGirr83 Rich McGirr added a comment - Though in the ACP it still displays the red coloring
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          Though in the ACP it still displays the red coloring

          Yes, that was intentional. The ACP is not a "style" like prosilver or subsilver and since the recaptcha theme is style dependent, a board could (and usually does when there are multiple styles available) have several different recaptcha themes in use so it makes no sense to try and theme the ACP to match when it likely won't anyway. Perhaps someday when the ACP can have custom styles applied similar to the board it would make sense.

          Show
          narqelion narqelion [X] (Inactive) added a comment - Though in the ACP it still displays the red coloring Yes, that was intentional. The ACP is not a "style" like prosilver or subsilver and since the recaptcha theme is style dependent, a board could (and usually does when there are multiple styles available) have several different recaptcha themes in use so it makes no sense to try and theme the ACP to match when it likely won't anyway. Perhaps someday when the ACP can have custom styles applied similar to the board it would make sense.
          Hide
          nickvergessen Joas Schilling added a comment -

          I think the style in the ACP should be changed, so it matches the style we use for the default-styles. Else the user may think, oh that looks disgusting and does not fit to my board-style.

          Show
          nickvergessen Joas Schilling added a comment - I think the style in the ACP should be changed, so it matches the style we use for the default-styles. Else the user may think, oh that looks disgusting and does not fit to my board-style.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              narqelion narqelion [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development