Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9835

Login Confirm Explain Not Working

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Styles
    • Labels:
      None

      Description

      Noticed in subSilver2,

      in captcha_default.html,

      {L_CONFIRM_EXPLAIN}

      should be,

      {L_LOGIN_CONFIRM_EXPLAIN}
      1. 9835.diff
        0.7 kB
        narqelion [X]

        Activity

        Hide
        marc1706 marc1706 added a comment -

        CONFIRM_EXPLAIN is declared inside language/yourlanguage/ucp.php and it works without any issues. LOGIN_CONFIRM_EXPLAIN is used when someone tried to log into your acccount without the correct password, exceeded the maximum allowed numbers of failed logins, and you have to enter the captcha in order to confirm that you are not a bot.

        I suggest to close this ticket.

        Show
        marc1706 marc1706 added a comment - CONFIRM_EXPLAIN is declared inside language/ yourlanguage /ucp.php and it works without any issues. LOGIN_CONFIRM_EXPLAIN is used when someone tried to log into your acccount without the correct password, exceeded the maximum allowed numbers of failed logins, and you have to enter the captcha in order to confirm that you are not a bot. I suggest to close this ticket.
        Hide
        bantu Andreas Fischer added a comment - - edited

        @jrolson: Could you please elaborate why this is an issue and what the actual issue is?

        Show
        bantu Andreas Fischer added a comment - - edited @jrolson: Could you please elaborate why this is an issue and what the actual issue is?
        Hide
        narqelion narqelion [X] (Inactive) added a comment -

        I am fairly sure he is talking about the template difference between ps & ss2 when you are presented with the captcha after x failed login attempts. If you look at the screen caps I attached you will notice that ss2 includes both strings whereas ps uses only the one specific to failed login attempts. I think he is saying that ss2 should not display L_CONFIRM_EXPLAIN if case = exceeded login attempts.

        ss2:
        http://www.dilligaff.org/images/ss2.jpg

        ps:
        http://www.dilligaff.org/images/ps.jpg

        Show
        narqelion narqelion [X] (Inactive) added a comment - I am fairly sure he is talking about the template difference between ps & ss2 when you are presented with the captcha after x failed login attempts. If you look at the screen caps I attached you will notice that ss2 includes both strings whereas ps uses only the one specific to failed login attempts. I think he is saying that ss2 should not display L_CONFIRM_EXPLAIN if case = exceeded login attempts. ss2: http://www.dilligaff.org/images/ss2.jpg ps: http://www.dilligaff.org/images/ps.jpg
        Hide
        narqelion narqelion [X] (Inactive) added a comment -

        Just in case my comment wasn't clear, there is a bug here, just not Major - more like Trivial. The problem is in the subsilver2 captcha_default.html template. When a user who exceeds their login attempts is presented with the default CAPTCHA they are also seeing a registration language string because the same CAPTCHA template is used for both /ucp.php?mode=login and /ucp.php?mode=register. I have attached a patch to make subsilver2 show the registration language only if /ucp.php?mode=register, just like Prosilver.

        Show
        narqelion narqelion [X] (Inactive) added a comment - Just in case my comment wasn't clear, there is a bug here, just not Major - more like Trivial. The problem is in the subsilver2 captcha_default.html template. When a user who exceeds their login attempts is presented with the default CAPTCHA they are also seeing a registration language string because the same CAPTCHA template is used for both /ucp.php?mode=login and /ucp.php?mode=register. I have attached a patch to make subsilver2 show the registration language only if /ucp.php?mode=register, just like Prosilver.
        Hide
        RMcGirr83 Rich McGirr added a comment -

        Fix is verifed

        Show
        RMcGirr83 Rich McGirr added a comment - Fix is verifed

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            jrolson jrolson
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development