Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9825

Run tests on sqlite if available and no test db configured

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.8-RC1
    • Component/s: None
    • Labels:
      None

      Description

      The database unit test section currently throws a message / an error saying that you have to create a test_config.php file to enable database tests.

      Since the tests now support sqlite we can change the logic to the following.

      if (test_config.php exists) { use test_config.php } else if (sqlite is available) { silently use sqlite } else { echo error }

        Issue Links

          Activity

          Hide
          igorw Igor Wiedler [X] (Inactive) added a comment - - edited

          May need to be revisited and adjusted once we have sqlite3 support, but looks good for now. EDIT: for ascraeus that would be.

          Show
          igorw Igor Wiedler [X] (Inactive) added a comment - - edited May need to be revisited and adjusted once we have sqlite3 support, but looks good for now. EDIT: for ascraeus that would be.
          Hide
          igorw Igor Wiedler [X] (Inactive) added a comment -

          Can you please add tests/phpbb_unit_tests.sqlite2 to .gitignore? And maybe tests/test_config.php as well, since it's related.

          Show
          igorw Igor Wiedler [X] (Inactive) added a comment - Can you please add tests/phpbb_unit_tests.sqlite2 to .gitignore? And maybe tests/test_config.php as well, since it's related.
          Hide
          igorw Igor Wiedler [X] (Inactive) added a comment -

          Added those myself.

          Show
          igorw Igor Wiedler [X] (Inactive) added a comment - Added those myself.
          Hide
          igorw Igor Wiedler [X] (Inactive) added a comment -

          PHPUnit version needs to be >= 3.4.13, not >= 3.4.15.

          http://github.com/evil3/phpbb3/compare/ticket%2F9825

          Show
          igorw Igor Wiedler [X] (Inactive) added a comment - PHPUnit version needs to be >= 3.4.13, not >= 3.4.15. http://github.com/evil3/phpbb3/compare/ticket%2F9825

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              bantu Andreas Fischer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development