Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9824

Git hook quirks

    XMLWordPrintable

Details

    • Task
    • Status: Unverified Fix (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.0.7-PL1
    • 3.0.9-RC1
    • None
    • None
    • OS X 10.6.4

    Description

      The git hooks have following quirks:

      1. The prepare-msg (I believe) hook adds a space at the end of the PHPBB3-number line, which makes the message be rejected unless the space is removed manually.

      2. A newline after PHPBB3-number is not accepted by the message validation hook. Git does not care about such newlines, in fact it even adds them when ammending.

      3. Empty commit messages trigger a really awkward validation message. Instead, if the commit message is empty (after removal of comments) it should just be handed on to git, which will then handle it gracefully.

      It would be nice if the message rejection were a bit less strict and a bit more helpful in general.

      Attachments

        Activity

          People

            Oleg Oleg [X] (Inactive)
            igorw Igor Wiedler [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: