Details

    • Type: Task
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.9-RC1
    • Component/s: None
    • Labels:
      None
    • Environment:
      OS X 10.6.4

      Description

      The git hooks have following quirks:

      1. The prepare-msg (I believe) hook adds a space at the end of the PHPBB3-number line, which makes the message be rejected unless the space is removed manually.

      2. A newline after PHPBB3-number is not accepted by the message validation hook. Git does not care about such newlines, in fact it even adds them when ammending.

      3. Empty commit messages trigger a really awkward validation message. Instead, if the commit message is empty (after removal of comments) it should just be handed on to git, which will then handle it gracefully.

      It would be nice if the message rejection were a bit less strict and a bit more helpful in general.

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Work in progress.

        Show
        bantu Andreas Fischer added a comment - Work in progress.
        Hide
        Oleg Oleg [X] (Inactive) added a comment - - edited

        Got this when rebasing:

        /home/pie/apps/thirdparty/phpbb/.git/rebase-merge/git-rebase-todo: 18 lines, 730 characters.
        fatal: ref HEAD is not a symbolic ref
        [detached HEAD 6d9e93f] [ticket/9824] Handle empty commit messages in commit-msg hook.
         1 files changed, 10 insertions(+), 0 deletions(-)
        Successfully rebased and updated refs/heads/ticket/9824.
        

        Looks like it may be related to:

        # get branch name
        branch="$(git symbolic-ref HEAD)"
        

        Show
        Oleg Oleg [X] (Inactive) added a comment - - edited Got this when rebasing: /home/pie/apps/thirdparty/phpbb/.git/rebase-merge/git-rebase-todo: 18 lines, 730 characters. fatal: ref HEAD is not a symbolic ref [detached HEAD 6d9e93f] [ticket/9824] Handle empty commit messages in commit-msg hook. 1 files changed, 10 insertions(+), 0 deletions(-) Successfully rebased and updated refs/heads/ticket/9824. Looks like it may be related to: # get branch name branch="$(git symbolic-ref HEAD)"
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        I am not a fan of commit-msg hook rejecting lowercase commit messages. I use messages like "fixup" for fixup commits that eventually get squashed.

        Show
        Oleg Oleg [X] (Inactive) added a comment - I am not a fan of commit-msg hook rejecting lowercase commit messages. I use messages like "fixup" for fixup commits that eventually get squashed.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        This should be tested by someone else (I tested it by committing some stuff).

        Show
        Oleg Oleg [X] (Inactive) added a comment - This should be tested by someone else (I tested it by committing some stuff).

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            igorw Igor Wiedler [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development