Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9766

phpbb_default_captcha::delete_code() takes no argument but uses $confirm_id

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None

      Description

      phpbb_default_captcha::delete_code() takes no argument but uses $confirm_id

      	function delete_code()
      	{
      		global $db, $user;
       
      		$sql = 'DELETE FROM ' . CONFIRM_TABLE . "
      			WHERE confirm_id = '" . $db->sql_escape($confirm_id) . "'
      				AND session_id = '" . $db->sql_escape($user->session_id) . "'
      				AND confirm_type = " . $this->type;
      		$db->sql_query($sql);
      	}

        Activity

        Hide
        marc1706 marc1706 added a comment - - edited

        I'm not quite sure why that function is still present as it seems like it isn't used anymore:

        // $this->delete_code(); commented out to allow posting.php to repeat the question

        Anyhow, I think that $confirm_id is supposed to be $this->confirm_id.

        Show
        marc1706 marc1706 added a comment - - edited I'm not quite sure why that function is still present as it seems like it isn't used anymore: // $this->delete_code(); commented out to allow posting.php to repeat the question Anyhow, I think that $confirm_id is supposed to be $this->confirm_id.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            bantu Andreas Fischer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development