Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9757

Empty template variable HISTORY_TITLE in ucp_pm_history

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: None
    • Labels:
      None

      Description

      hi,

      i ve found this in ucp_pm_history.html (originally found in black_pearl but i think it's in all styles)

      This is the original line i m talking about:

      <div><div class="tbl-h-l"><div class="tbl-h-r"><div class="tbl-h-c"><div class="tbl-title">

      {L_MESSAGE_HISTORY} - {HISTORY_TITLE}</div></div></div></div>

      The above leaves a blanco replacment on HISTORY _TITLE wich makes it looks somewhat like this ..."Message History - " (somewhat like this ..because my language file is modified there!)

      I'm not sure if this is the best way to solve but to at least fill the blanc with something logical i've changed this line of code to:

      <div><div class="tbl-h-l"><div class="tbl-h-r"><div class="tbl-h-c"><div class="tbl-title">{L_MESSAGE_HISTORY}

      -

      {SUBJECT}

      </div></div></div></div>

        Activity

        Hide
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

        Confirmed with prosilver and subsilver2.

        Show
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment - Confirmed with prosilver and subsilver2.
        Hide
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

        Ok, fixing this actually makes the history review look worse (IMO).

        Message history: Re: IPv6 address test

        Understanding that this template variable probably should be filled, my proposed solution would be to fill

        {HISTORY_TITLE}

        , but remove it from both prosilver and subsilver2.

        Would that offend any custom style authors?

        Show
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment - Ok, fixing this actually makes the history review look worse (IMO). Message history: Re: IPv6 address test Understanding that this template variable probably should be filled, my proposed solution would be to fill {HISTORY_TITLE} , but remove it from both prosilver and subsilver2. Would that offend any custom style authors?

          People

          • Assignee:
            A_Jelly_Doughnut A_Jelly_Doughnut
            Reporter:
            Joshua203 Joshua 203 [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development