Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9715

Fix email address regular expression or adjust email regular expression unit tests

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.8-RC1
    • Component/s: None
    • Labels:
      None

      Description

      There were 2 failures:
       
      1) phpbb_regex_email_test::test_negative_match with data set #2 ('Foo.@example.com')
      Failed asserting that <integer:1> matches expected <integer:0>.
       
       
      2) phpbb_regex_email_test::test_negative_match with data set #3 ('foo..123@example.com')
      Failed asserting that <integer:1> matches expected <integer:0>.
      

      It has to be decided whether we want to fix the regex or exclude those two tests.

      The following tests are already excluded because the formats aren't widely used.

      //array('"John Doe"@example.com'),
      //array('Alice@[192.168.2.1]'),		// IPv4
      //array('Bob@[2001:0db8:85a3:08d3:1319:8a2e:0370:7344]'), // IPv6
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bantu Andreas Fischer
                Reporter:
                bantu Andreas Fischer
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: