Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9693

generate_smilies clean up

          Details

          • Type: Improvement
          • Status: Unverified Fix
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.0.7-PL1
          • Fix Version/s: 3.1.0-a1
          • Component/s: Other
          • Labels:
            None

            Description

            In the function generate_smilies() the global $auth isn't used

            Affected file : root/includes/functions_posting.php

            Find :

            function generate_smilies($mode, $forum_id)

            Find :

            	global $auth, $db, $user, $config, $template;

            Replace with :

            	global $db, $user, $config, $template;

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              bantu Andreas Fischer added a comment -

              That might be the case but there is no reason to change it.

              Show
              bantu Andreas Fischer added a comment - That might be the case but there is no reason to change it.
              Hide
              Permalink
              Oleg Oleg [X] (Inactive) added a comment -

              There is another one in posting_gen_attachment_entry, fix for which is included in the pull request.

              Show
              Oleg Oleg [X] (Inactive) added a comment - There is another one in posting_gen_attachment_entry, fix for which is included in the pull request.

                People

                • Assignee:
                  Oleg Oleg [X] (Inactive)
                  Reporter:
                  leviatan21 leviatan21 [X] (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development