Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9673 Compatibility with HipHop
  3. PHPBB3-9672

Replace preg_replace with /e modifier with preg_replace_callback in includes/ucp/ucp_pm_options.php

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Invalid
    • 3.0.7-PL1
    • 3.1.0-b4
    • Other
    • None

    Description

      includes/ucp/ucp_pm_options.php uses preg_replace with the /e modifier, which evals the result before replacing. This is inefficient and breaks compatibility with HipHop. This patch removes those cases and replaces them with inline code.

      Attachments

        Activity

          People

            nickvergessen Joas Schilling [X] (Inactive)
            ckwalsh Cullen Walsh [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: