Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9673 Compatibility with HipHop
  3. PHPBB3-9667

Replace preg_replace with /e modifier with preg_replace_callback in includes/bbcode.php

    Details

    • Type: Sub-task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Invalid
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.1.0-b4
    • Component/s: None
    • Labels:
      None

      Description

      includes/bbcode.php uses preg_replace with the /e modifier, which evals the result before replacing. This is inefficient and breaks compatibility with HipHop. This patch removes those cases and replaces them with a callback.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nickvergessen Joas Schilling [X] (Inactive)
                Reporter:
                ckwalsh Cullen Walsh [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: