Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9662

Search interval applied inconsistently

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Search
    • Labels:
      None
    • Environment:
      PHP 5.2.8, MySQL 5.0.67, phpMyAdmin 3.1.1, Firefox 3.6.3, IE 8, etc.

      Description

      By default there is a search delay/limit for members and guests. For example: 30 seconds for guests and 5 seconds for members.

      When a member or guest viewing "active topics", "unanswered posts, etc and the member/guest is refreshing that page (F5 or hard refresh with CTRL+F5) there is no problem. This is because "active topics", "unanswered posts" etc. are not using the search index database table?

      But when a user/guest used the search function (searchbox) they have to wait the given seconds (between searches in ACP) before they can use "active topics", "unanswered posts", etc again.

        Activity

        Hide
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

        I do reproduce this one. user_last_search time is only updated on a keyword / author search (i.e. a search which calls a plugin), but is always checked in search.php.

        Is the proper fix to exclude the "active topics" or "unanswered posts" search types from the check or to always update user_last_search? I think the latter.

        Show
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment - I do reproduce this one. user_last_search time is only updated on a keyword / author search (i.e. a search which calls a plugin), but is always checked in search.php. Is the proper fix to exclude the "active topics" or "unanswered posts" search types from the check or to always update user_last_search? I think the latter.
        Hide
        nickvergessen Joas Schilling added a comment -

        I'm not sure. I could imagine both ways, but I personally would exclude active and unread search form the time check.

        Show
        nickvergessen Joas Schilling added a comment - I'm not sure. I could imagine both ways, but I personally would exclude active and unread search form the time check.

          People

          • Assignee:
            A_Jelly_Doughnut A_Jelly_Doughnut
            Reporter:
            remon remon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development