Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9649

Moderator queue does not display icon if the new post is made in old thread

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1, 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None
    • Environment:
      PHP Version 5.2.12
      MySQL 5.0.90-community

      Description

      Currently, when new posts needs approval (first post approval feature) there is a small icon displayed in the forum index alerting moderators about the queue.

      This function works (icon is displayed) on my site if the new post is a new topic, but it doesn't show if it was made as a reply to old thread.
      -> You need to go to MCP to get notified if the topic is out of sight in page 2 and above.

      Discussion in QA forums
      http://www.phpbb.com/community/viewtopic.php?f=95&t=2094158#p12804211

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          I think this one was set to 3.1 as we need to add a new column forum_posts_real for a proper fix and the work about that is too much for 3.0?

          Show
          nickvergessen Joas Schilling added a comment - I think this one was set to 3.1 as we need to add a new column forum_posts_real for a proper fix and the work about that is too much for 3.0?
          Hide
          bantu Andreas Fischer added a comment -

          Ah yeah. That explains it, but that information was not in the ticket until now.

          Show
          bantu Andreas Fischer added a comment - Ah yeah. That explains it, but that information was not in the ticket until now.
          Hide
          thinkagain thinkagain [X] (Inactive) added a comment -

          Correct me if I am wrong but I believe the existing function is working perfectly as coded and intended according to the following:
          http://tracker.phpbb.com/browse/PHPBB3-8422
          [Feature] Add unapproved topic icon for moderators on forum list. (Bug #46865)

          So what is there to fix? This seems like another bogus bug report to me. The only time you are supposed to be presented with an unapproved icon on the forum index is if there are unapproved topics not unapproved posts. I would not like to see the forum index page littered with icons for each and every unapproved post that isn't a topic starter. It is currently a nice feature to have only new topics needing attention flagged on the index without having to go into the MCP to see if there are any and I love the fact that the icon links directly to the 'Topics awaiting approval' tab of the MCP. Where would the icon redirect if a forum had both unapproved topics and unapproved replies? I hope that you don't change the current behavior but if you do you should provide an easy way (GUI based) to disable the inclusion of non-topic posts as a trigger for the icon.

          Show
          thinkagain thinkagain [X] (Inactive) added a comment - Correct me if I am wrong but I believe the existing function is working perfectly as coded and intended according to the following: http://tracker.phpbb.com/browse/PHPBB3-8422 [Feature] Add unapproved topic icon for moderators on forum list. (Bug #46865) So what is there to fix? This seems like another bogus bug report to me. The only time you are supposed to be presented with an unapproved icon on the forum index is if there are unapproved topics not unapproved posts. I would not like to see the forum index page littered with icons for each and every unapproved post that isn't a topic starter. It is currently a nice feature to have only new topics needing attention flagged on the index without having to go into the MCP to see if there are any and I love the fact that the icon links directly to the 'Topics awaiting approval' tab of the MCP. Where would the icon redirect if a forum had both unapproved topics and unapproved replies? I hope that you don't change the current behavior but if you do you should provide an easy way (GUI based) to disable the inclusion of non-topic posts as a trigger for the icon.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          There is a patch out there... somewhere... note to self.

          Show
          Oleg Oleg [X] (Inactive) added a comment - There is a patch out there... somewhere... note to self.
          Hide
          nickvergessen Joas Schilling added a comment -

          Might also get fixed by soft delete, as the problem also applies to soft deleting status.

          Show
          nickvergessen Joas Schilling added a comment - Might also get fixed by soft delete, as the problem also applies to soft deleting status.
          Hide
          nickvergessen Joas Schilling added a comment -

          Still needs fixing

          Show
          nickvergessen Joas Schilling added a comment - Still needs fixing

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              lurttinen Martti Lokka
            • Votes:
              2 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development