Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9645

XHTML error on phpinfo page in ACP

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.10-RC1
    • Component/s: ACP
    • Labels:
      None

      Description

      Noticed this xhtml error on the PHP Information page:
      <h2><a name="module_Zend Optimizer">Zend Optimizer</a></h2>

      the "name" must be a single token...
      name="module_Zend Optimizer" ---> name="module_Zend_Optimizer"

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        The anchor attributes exist so that it is possible to link to a particular extension on that page.

        Instead of removing them I would accept a patch that changes spaces to underscores.

        Show
        Oleg Oleg [X] (Inactive) added a comment - The anchor attributes exist so that it is possible to link to a particular extension on that page. Instead of removing them I would accept a patch that changes spaces to underscores.
        Hide
        callum95 callum95 added a comment - - edited

        [13:32:50] <callumacrae> http://tracker.phpbb.com/browse/PHPBB3-9645
        [13:33:13] <callumacrae> Is there any point in fixing that? XD
        [13:34:24] <callumacrae> hang on, easy fix
        [13:34:42] <callumacrae> the names aren't used
        [13:35:17] <callumacrae> preg_replace and a fancy regex to remove all of the names?
        [13:37:58] <bantu> yeah, something like that probably
        [13:38:00] <naderman> sounds simple enough
        [13:38:02] <naderman> yup

        I can't think of a use case of being able to link to a section in a restricted area of the ACP.

        Show
        callum95 callum95 added a comment - - edited [13:32:50] <callumacrae> http://tracker.phpbb.com/browse/PHPBB3-9645 [13:33:13] <callumacrae> Is there any point in fixing that? XD [13:34:24] <callumacrae> hang on, easy fix [13:34:42] <callumacrae> the names aren't used [13:35:17] <callumacrae> preg_replace and a fancy regex to remove all of the names? [13:37:58] <bantu> yeah, something like that probably [13:38:00] <naderman> sounds simple enough [13:38:02] <naderman> yup I can't think of a use case of being able to link to a section in a restricted area of the ACP.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Replacing spaces with underscores is only marginally more work and does not reduce functionality.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Replacing spaces with underscores is only marginally more work and does not reduce functionality.
        Hide
        callum95 callum95 added a comment -

        I've also reported this bug to The PHP Group, I'll let you know what happens.

        Show
        callum95 callum95 added a comment - I've also reported this bug to The PHP Group, I'll let you know what happens.
        Show
        Oleg Oleg [X] (Inactive) added a comment - https://bugs.php.net/bug.php?id=55415

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            VSE Matt Friedman
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development