Details

      Description

      Currently the database tests only contain most of the SELECT-queries.

      UPDATEs and INSERTs are still missing.

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Attached is the result for Postgres 8.4. It looks like you have to add an order an in the SELECT query.

        Show
        bantu Andreas Fischer added a comment - Attached is the result for Postgres 8.4. It looks like you have to add an order an in the SELECT query.
        Hide
        bantu Andreas Fischer added a comment -

        The coding style, especially those complex arrays, look rather suboptimal.
        http://github.com/nickvergessen/phpbb3/commit/4467aa4b2beb9abe2af22802d30d39d7aa4488cb

        Maybe add "$sql =" for each query, maybe open/close arrays with multiple subarrays on its own line.

        Show
        bantu Andreas Fischer added a comment - The coding style, especially those complex arrays, look rather suboptimal. http://github.com/nickvergessen/phpbb3/commit/4467aa4b2beb9abe2af22802d30d39d7aa4488cb Maybe add "$sql =" for each query, maybe open/close arrays with multiple subarrays on its own line.
        Hide
        bantu Andreas Fischer added a comment -

        Added PHPBB3-9625 to the commit messages.

        Show
        bantu Andreas Fischer added a comment - Added PHPBB3-9625 to the commit messages.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development