Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9611

Increase entropy in activation keys

    XMLWordPrintable

Details

    • Improvement
    • Status: Unverified Fix (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.0.7-PL1
    • 3.0.8-RC1
    • None
    • None

    Description

      To increase entropy

      $user_actkey = gen_rand_string(10);
      		 
      $key_len = 54 - (strlen($server_url));
      		 
      $key_len = ($key_len < 6) ? 6 : $key_len;
      		 
      $user_actkey = substr($user_actkey, 0, $key_len);

      should be replaces with

      $user_actkey = gen_rand_string(rand(6, 10));

      c0836e8835f0b3105baecdc710cd101920d8339b already changed this in ucp_remind.php, but this code block still appears in acp_users.php, ucp_profile.php and ucp_register.php.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-9612 Split gen_rand_string() into gen_rand_string() and gen_rand_string_friendly()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Unverified Fix
          is related to

          Bug - A problem which impairs or prevents the functions of the product. PHPBB3-5164 Honor minimum and maximum password length in generated passwords as much as possible.

          • Major - Major loss of function.
          • Closed

          Activity

            People

              bantu Andreas Fischer [X] (Inactive)
              bantu Andreas Fischer [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: