Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9611

Increase entropy in activation keys

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: None
    • Labels:
      None

      Description

      To increase entropy

      $user_actkey = gen_rand_string(10);
      $key_len = 54 - (strlen($server_url));
      $key_len = ($key_len < 6) ? 6 : $key_len;
      $user_actkey = substr($user_actkey, 0, $key_len);
      

      should be replaces with

      $user_actkey = gen_rand_string(rand(6, 10));
      

      c0836e8835f0b3105baecdc710cd101920d8339b already changed this in ucp_remind.php, but this code block still appears in acp_users.php, ucp_profile.php and ucp_register.php.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          confirm_box() can also use

          $confirm_key = gen_rand_string(mt_rand(6, 10));

          Show
          bantu Andreas Fischer added a comment - confirm_box() can also use $confirm_key = gen_rand_string(mt_rand(6, 10));

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              bantu Andreas Fischer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development