Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9609

Use send_status_line instead of calling header

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: None
    • Labels:
      None

      Description

      Per http://tracker.phpbb.com/browse/PHPBB3-7782, convert remaining header calls.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          Is there a pressing reason why existing calls should be adjusted?

          Show
          bantu Andreas Fischer added a comment - Is there a pressing reason why existing calls should be adjusted?
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          If the logic in send_status_line is there for a reason, then all header() calls are essentially wrong/broken for that reason.

          Show
          Oleg Oleg [X] (Inactive) added a comment - If the logic in send_status_line is there for a reason, then all header() calls are essentially wrong/broken for that reason.
          Hide
          bantu Andreas Fischer added a comment -

          Well, I wasn't even aware of it being broken.

          Show
          bantu Andreas Fischer added a comment - Well, I wasn't even aware of it being broken.
          Hide
          bantu Andreas Fischer added a comment -

          I have converted the calls to header() that set the HTTP status code.

          What I do not know at this point is why "503 Service Unavailable" was always sent as "HTTP/1.1" instead of "HTTP/1.0".

          Show
          bantu Andreas Fischer added a comment - I have converted the calls to header() that set the HTTP status code. What I do not know at this point is why "503 Service Unavailable" was always sent as "HTTP/1.1" instead of "HTTP/1.0".
          Hide
          bantu Andreas Fischer added a comment -

          The RFC for HTTP/1.0 shows support for the "503 Service Unavailable" status code; setting patch as solution.

          Show
          bantu Andreas Fischer added a comment - The RFC for HTTP/1.0 shows support for the "503 Service Unavailable" status code; setting patch as solution.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development