Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9557 Update coding guidelines for 3.1 and PHP >= 5.2
  3. PHPBB3-9574

Drop fallback implementations

          Details

          • Type: Sub-task
          • Status: Unverified Fix
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.1.0-a1
          • Fix Version/s: 3.1.0-a1
          • Component/s: None
          • Labels:
            None

            Description

            phpBB 3.0 includes many fallbacks for functions not included in older PHP versions. There are several of these in includes/functions.php.

            Since phpBB 3.1 will have a minimum of PHP 5.2, those should be removed.

              Issue Links

              caused

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-10329 Function pcre_utf8_support() needs the "phpbb_" prefix

              • Major - Major loss of function.
              • Unverified Fix

                Activity

                Ascending order - Click to sort in descending order
                6 older comments
                Hide
                Permalink
                igorw Igor Wiedler [X] (Inactive) added a comment -

                Good catch, added the $new link, where do you want the documentation? Wiki? Where exactly?

                Show
                igorw Igor Wiedler [X] (Inactive) added a comment - Good catch, added the $new link, where do you want the documentation? Wiki? Where exactly?
                Hide
                Permalink
                A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

                I can't speak directly for Andreas, but I'm pretty sure he was talking about inline phpdoc comments in functions.php.

                Show
                A_Jelly_Doughnut A_Jelly_Doughnut added a comment - I can't speak directly for Andreas, but I'm pretty sure he was talking about inline phpdoc comments in functions.php.
                Hide
                Permalink
                igorw Igor Wiedler [X] (Inactive) added a comment -

                Got it, added.

                Show
                igorw Igor Wiedler [X] (Inactive) added a comment - Got it, added.
                Hide
                Permalink
                bantu Andreas Fischer added a comment -

                Yes, I was talking about @return

                Show
                bantu Andreas Fischer added a comment - Yes, I was talking about @return
                Hide
                Permalink
                naderman Nils Adermann added a comment -

                Admin note language key & code should be kept for future version warnings.

                Show
                naderman Nils Adermann added a comment - Admin note language key & code should be kept for future version warnings.

                  People

                  • Assignee:
                    igorw Igor Wiedler [X] (Inactive)
                    Reporter:
                    igorw Igor Wiedler [X] (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development