Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0-a1
    • Labels:
      None

      Description

      Discussion on Area51: http://area51.phpbb.com/phpBB/viewtopic.php?f=84&t=32787

      Ideas in short version:

      • View groups on teampage (also without m_ or a_ permissions)
      • Custom sort groups
      • View users in multiple groups
      • Add spacer between groups

      (If anything is missing or you have a better title, feel free to add it )

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Also, if I remember correctly the option to order groups alphabetically is only given for the legend. I think it either should to be provided for both legend and teampage or for neither of them.

          Show
          Oleg Oleg [X] (Inactive) added a comment - Also, if I remember correctly the option to order groups alphabetically is only given for the legend. I think it either should to be provided for both legend and teampage or for neither of them.
          Hide
          nickvergessen Joas Schilling added a comment -

          Fixed the bug with the empty groups.

          Regarding the sort-by-name:
          I just disabled the option now by default.
          I don't think you really need it on the teampage, as there should be fewer groups.

          Show
          nickvergessen Joas Schilling added a comment - Fixed the bug with the empty groups. Regarding the sort-by-name: I just disabled the option now by default. I don't think you really need it on the teampage, as there should be fewer groups.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Empty groups are still empty.

          Show
          Oleg Oleg [X] (Inactive) added a comment - Empty groups are still empty.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Proper fix for empty groups: https://github.com/nickvergessen/phpbb3/pull/1

          I found another possible issue. Suppose I have a user in two groups: test1 and test2. Let's say the user's default group is test2. However, if on teampage test1 is displayed before test2, and users are only displayed once, then this user would be displayed under test1 even though their default group is test2.

          It makes sense, I think, to show the user in their default group when their default group is displayed on the teampage.

          When their default group is not displayed they should probably be displayed in the first displayed group.

          Show
          Oleg Oleg [X] (Inactive) added a comment - Proper fix for empty groups: https://github.com/nickvergessen/phpbb3/pull/1 I found another possible issue. Suppose I have a user in two groups: test1 and test2. Let's say the user's default group is test2. However, if on teampage test1 is displayed before test2, and users are only displayed once, then this user would be displayed under test1 even though their default group is test2. It makes sense, I think, to show the user in their default group when their default group is displayed on the teampage. When their default group is not displayed they should probably be displayed in the first displayed group.
          Hide
          nickvergessen Joas Schilling added a comment -

          Well

          						if (!$config['teampage_multiple'] && ($group_id != $groups_ary[$row['default_group']]['group_id']) && $groups_ary[$row['default_group']]['group_teampage'])
          						{
          							// Display users in there primary group, instead of the first group, when it is displayed on the page.
          							continue;
          						}

          would do that.

          Any other opinions on this behaviour?

          Show
          nickvergessen Joas Schilling added a comment - Well if (!$config['teampage_multiple'] && ($group_id != $groups_ary[$row['default_group']]['group_id']) && $groups_ary[$row['default_group']]['group_teampage']) { // Display users in there primary group, instead of the first group, when it is displayed on the page. continue; } would do that. Any other opinions on this behaviour?

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development