Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9519

Replace remaining is_writable() calls with phpbb_is_writable().

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Other
    • Labels:
      None

      Description

      is_writable() doesn't work properly under Windows, phpbb_is_writable() should be used instead.

        Activity

        Show
        nickvergessen Joas Schilling added a comment - Fix for 3.0 in http://github.com/nickvergessen/phpbb3/compare/phpbb:develop-olympus...nickvergessen:ticket/9519 3.1 coming soon.
        Hide
        nickvergessen Joas Schilling added a comment -

        There are no other calls in 3.1, so the patch is the same for both.

        Show
        nickvergessen Joas Schilling added a comment - There are no other calls in 3.1, so the patch is the same for both.
        Hide
        bantu Andreas Fischer added a comment -

        Looks like at least in acm_*.php you have to check if the function is actually available before calling it.

        Show
        bantu Andreas Fischer added a comment - Looks like at least in acm_*.php you have to check if the function is actually available before calling it.
        Show
        bantu Andreas Fischer added a comment - Like this. http://tracker.phpbb.com/browse/PHPBB3-7901?focusedCommentId=28367&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_28367
        Hide
        nickvergessen Joas Schilling added a comment -

        fixed

        Show
        nickvergessen Joas Schilling added a comment - fixed
        Hide
        nickvergessen Joas Schilling added a comment -

        The merge to 3.1 only contains the first commit, and the one to 3.0 got an email for each. Is that intended?

        Show
        nickvergessen Joas Schilling added a comment - The merge to 3.1 only contains the first commit, and the one to 3.0 got an email for each. Is that intended?
        Hide
        bantu Andreas Fischer added a comment -

        The merge contains all 4 commits for this ticket. See merge commit http://github.com/phpbb/phpbb3/commit/e4ff780c1370d9f743da0fffc70b98be0c7cfe92 I don't know about emails.

        Show
        bantu Andreas Fischer added a comment - The merge contains all 4 commits for this ticket. See merge commit http://github.com/phpbb/phpbb3/commit/e4ff780c1370d9f743da0fffc70b98be0c7cfe92 I don't know about emails.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            ToonArmy Chris Smith
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development