Details
-
Bug
-
Status: Closed (View Workflow)
-
Resolution: Fixed
-
3.0.x
-
None
-
None
-
PHP Environment:
Database:
Description
It looks like conversion of Birthdays by Niels MOD is not correct. Default phpBB3 birthdays values format doesn't contain leding zero, i.e.
2- 8-1970
|
return gmdate('d-m-Y', $birthday * 86400 + 1);
|
So some converted birthdays (like 02-08-1970) won't be shown on index because of select query in index.php
WHERE user_birthday LIKE '" . $db->sql_escape(sprintf('%2d-%2d-', $now['mday'], $now['mon'])) . "%'
|
Suggested fix (for instance):
OPEN
|
install\convertors\functions_phpbb20.php
|
|
|
FIND
|
// The birthday mod from niels is using this code to transform to day/month/year
|
return gmdate('d-m-Y', $birthday * 86400 + 1);
|
|
|
REPLACE WITH
|
$month = gmdate('n', $birthday * 86400 + 1);
|
$day = gmdate('j', $birthday * 86400 + 1);
|
$year = gmdate('Y', $birthday * 86400 + 1);
|
return sprintf('%2d-%2d-%4d', $day, $month, $year);
|
The fix can be simplified in some way for sure - it's just to show the thought 