Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9361

Edit account settings - Improved clarification needed

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.x
    • Fix Version/s: 3.0.10-RC1
    • Component/s: Other
    • Labels:
      None

      Description

      If an e-mail address is being changed in the UCP, but it is not entered again in the "Confirm e-mail address:", the return is: "The e-mail addresses you entered do not match." If left blank, I believe it should say something like: "You must enter your e-mail address again in the confirm e-mail address.", specifically the "Confirm e-mail address:", in order to inform the user they must enter it twice for the forums to consider changing it.

      When filling out a "New password:", but the "Confirm password:" is left blank, the return is: "The passwords you entered do not match." and "The current password you entered is incorrect.". Obviously a blank password in the confirm password box will always return a "do not match" and "incorrect" message, and should always be rejected. This should be clarified with a reply back saying something like: "You must enter your password again in the confirm password.". A specific message such as that would be more user-friendly.

      Entering some random password in the "Confirm password:", and leaving everything else blank will return "Your profile has been updated.". The reply back should say "No changes were made.", since the original password remains unchanged.

      Simply entering a new password in the "Current password:" box only, and clicking Submit, returns the message "Your profile has been updated.". The reply back should be "No changes were made.".

      Let's say you click your "Edit account settings" and immediately enter some random e-mail address in the "Confirm e-mail address:" box, but leave your original e-mail address unchanged, then click Submit. The reply back is "Your profile has been updated.". No changes were actually made. The reply back should be "No changes were made."

        Activity

        Hide
        narqelion narqelion [X] (Inactive) added a comment -

        If an e-mail address is being changed in the UCP, but it is not entered again in the "Confirm e-mail address:", the return is: "The e-mail addresses you entered do not match." If left blank, I believe it should say something like: "You must enter your e-mail address again in the confirm e-mail address.", specifically the "Confirm e-mail address:", in order to inform the user they must enter it twice for the forums to consider changing it.

        The fact that the passwords do not match is sufficient, there is no need to get specific as to the details of why they don't match. The field descriptor language already clearly explains why you would need to enter data in the field with the existing language string, "Confirm e-mail address: You only need to specify this if you are changing your e-mail address."

        When filling out a "New password:", but the "Confirm password:" is left blank, the return is: "The passwords you entered do not match." and "The current password you entered is incorrect.".

        No actually it doesn't. When filling out a new password and not entering the new password in the 'Confirm password' field you only get "The passwords you entered do not match." returned. The only way you will get "The passwords you entered do not match." and "The current password you entered is incorrect." is if you forget to enter your current password or enter an incorrect password.

        Entering some random password in the "Confirm password:", and leaving everything else blank will return "Your profile has been updated."

        That behavior is reproducible.

        Simply entering a new password in the "Current password:" box only, and clicking Submit, returns the message "Your profile has been updated."

        That behavior is reproducible as well. Either detect and report that no changes were made as suggested by the OP, or refine the UI to disable the submit button until the appropriate combination of fields has been filled out. From a UI/UX standpoint disabling (not hiding) UI inputs that have dependencies is always preferable to allowing input leading to an error message, however in this case the quick and dirty way would be easier.

        Show
        narqelion narqelion [X] (Inactive) added a comment - If an e-mail address is being changed in the UCP, but it is not entered again in the "Confirm e-mail address:", the return is: "The e-mail addresses you entered do not match." If left blank, I believe it should say something like: "You must enter your e-mail address again in the confirm e-mail address.", specifically the "Confirm e-mail address:", in order to inform the user they must enter it twice for the forums to consider changing it. The fact that the passwords do not match is sufficient, there is no need to get specific as to the details of why they don't match. The field descriptor language already clearly explains why you would need to enter data in the field with the existing language string, "Confirm e-mail address: You only need to specify this if you are changing your e-mail address." When filling out a "New password:", but the "Confirm password:" is left blank, the return is: "The passwords you entered do not match." and "The current password you entered is incorrect.". No actually it doesn't. When filling out a new password and not entering the new password in the 'Confirm password' field you only get "The passwords you entered do not match." returned. The only way you will get "The passwords you entered do not match." and "The current password you entered is incorrect." is if you forget to enter your current password or enter an incorrect password. Entering some random password in the "Confirm password:", and leaving everything else blank will return "Your profile has been updated." That behavior is reproducible. Simply entering a new password in the "Current password:" box only, and clicking Submit, returns the message "Your profile has been updated." That behavior is reproducible as well. Either detect and report that no changes were made as suggested by the OP, or refine the UI to disable the submit button until the appropriate combination of fields has been filled out. From a UI/UX standpoint disabling (not hiding) UI inputs that have dependencies is always preferable to allowing input leading to an error message, however in this case the quick and dirty way would be easier.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            DarkGod DarkGod [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development