Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9341

Incorrectly named template vars

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.x
    • Fix Version/s: 3.1.0-a1
    • Component/s: Other
    • Labels:
      None

      Description

      In functions.php:

      		$tpl_prefix . 'BASE_URL'		=> $base_url,
      		'A_' . $tpl_prefix . 'BASE_URL'	=> addslashes($base_url),

      and:

      		$tpl_prefix . 'PREVIOUS_PAGE'	=> ($on_page == 1) ? '' : $base_url . "{$url_delim}start=" . (($on_page - 2) * $per_page),
      		$tpl_prefix . 'NEXT_PAGE'		=> ($on_page == $total_pages) ? '' : $base_url . "{$url_delim}start=" . ($on_page * $per_page),

      Seeing as they hold URIs, I believe they should be prefixed with U_ in the case of those currently without a prefix and UA_ for the one currently prefixed with only A_.

        Activity

        Hide
        Acyd Burn Meik Sievertsen [X] (Inactive) added a comment -

        Strictly speaking yes... but non-strictly it was intended to easily prefix them with users choice vars.

        Show
        Acyd Burn Meik Sievertsen [X] (Inactive) added a comment - Strictly speaking yes... but non-strictly it was intended to easily prefix them with users choice vars.
        Hide
        Thatbitextra Thatbitextra [X] (Inactive) added a comment -

        Yeah, I thought that might have been the case, but seeing as you already had the A_ one, I figured the others could be prefixed as well

        I forgot to mention that a user brought it up here, so it shows at least one user was confused by them not strictly following the coding guidelines.

        Show
        Thatbitextra Thatbitextra [X] (Inactive) added a comment - Yeah, I thought that might have been the case, but seeing as you already had the A_ one, I figured the others could be prefixed as well I forgot to mention that a user brought it up here , so it shows at least one user was confused by them not strictly following the coding guidelines.

          People

          • Assignee:
            dhruv.goel92 Dhruv Goel
            Reporter:
            Thatbitextra Thatbitextra [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development