Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9220

Blue border width when table in a div

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.x
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Other
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      The blue forumbg background on the right of e.g. the memberlist (or anywhere where a table is put in a forumbg div) is ~2px too wide. Only checked it in FF2.

        Activity

        Hide
        dhn Dominik Dröscher [X] (Inactive) added a comment -

        Note to myself: Also seems to have IE7 problems

        Show
        dhn Dominik Dröscher [X] (Inactive) added a comment - Note to myself: Also seems to have IE7 problems
        Hide
        prototech prototech added a comment -

        Also noticeable in Firefox 3.5. Seems to be caused by the negative margins from .forumbg table.table1... will look into it further.

        Show
        prototech prototech added a comment - Also noticeable in Firefox 3.5. Seems to be caused by the negative margins from .forumbg table.table1... will look into it further.
        Hide
        kynetic kynetic added a comment -

        Open styles/prosilver/theme/common.css

        Find:
        .forumbg table.table1

        { margin: 0 -2px -1px -1px; }

        Replace by:
        .forumbg table.table1

        { margin: 0 -2px -1px -1px; width: 100.1%; }
        Show
        kynetic kynetic added a comment - Open styles/prosilver/theme/common.css Find: .forumbg table.table1 { margin: 0 -2px -1px -1px; } Replace by: .forumbg table.table1 { margin: 0 -2px -1px -1px; width: 100.1%; }
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        There is no patch attached here - reopening to fix status.

        Show
        Oleg Oleg [X] (Inactive) added a comment - There is no patch attached here - reopening to fix status.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Patch by Kynetic.

        I cannot vouch for validity of this patch.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Patch by Kynetic. I cannot vouch for validity of this patch.
        Hide
        Hanakin Michael Miday added a comment - - edited

        not that this is really important but this is actually caused by improperly zeroing of margins

        .forumbg table.table1

        { margin: 0 -2px -1px -1px; }

        should be

        .forumbg table.table1

        { margin: 0 0 -1px 0 }

        after this there seems to be an extra px on either side of the forumbg which is y the author originally used negative margins but using margins to negate padding is never a good idea but he also included a separate class for the block in forumbg-table which is not used for anything so we can use it to change the padding to 4px as opposed to 5px. I am not sure if this would cause any issues anywhere else since this is the only place in the entire theme it is used. Have not test this in other browsers only in firefox. There is a hack for the margins for IE so i would suspect it might need changed as well but i cant not speak to ie at the moment.

        Show
        Hanakin Michael Miday added a comment - - edited not that this is really important but this is actually caused by improperly zeroing of margins .forumbg table.table1 { margin: 0 -2px -1px -1px; } should be .forumbg table.table1 { margin: 0 0 -1px 0 } after this there seems to be an extra px on either side of the forumbg which is y the author originally used negative margins but using margins to negate padding is never a good idea but he also included a separate class for the block in forumbg-table which is not used for anything so we can use it to change the padding to 4px as opposed to 5px. I am not sure if this would cause any issues anywhere else since this is the only place in the entire theme it is used. Have not test this in other browsers only in firefox. There is a hack for the margins for IE so i would suspect it might need changed as well but i cant not speak to ie at the moment.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            Thatbitextra Thatbitextra [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development