Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9166

Subsilver and prosilver CSS elements out of order.

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Styles
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      According to:
      http://www.w3.org/TR/CSS21/selector.html#dynamic-pseudo-classes

      Note that the A:hover must be placed after the A:link and A:visited rules, since otherwise the cascading rules will hide the 'color' property of the A:hover rule. Similarly, because A:active is placed after A:hover, the active color (lime) will apply when the user both activates and hovers over the A element.

      Which I think results in the required order being:
      link
      visited
      hover
      active
      However in the stylesheet.css the order is:

      a:link {
         color: #006597;
         text-decoration: none;
      }
       
      a:active,
      a:visited {
         color: #005784;
         text-decoration: none;
      }
       
      a:hover {
         color: #D46400;
         text-decoration: underline;
      }
      

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Suggested changes as patch against 3.0.7-pl1.

        I added a comment explaining the order requirement and changed selector order in another location where link styles are defined for consistency.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Suggested changes as patch against 3.0.7-pl1. I added a comment explaining the order requirement and changed selector order in another location where link styles are defined for consistency.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        I tested the patch and it does change underlining behavior in firefox 3.5.

        Without the patch, links are normally not underlined, when hovered they get underlined and when clicked stay underlined.

        With the patch links are normally still not underlined, when hovered they get underlined but when clicked they become not underlined again.

        You need to click a link and hold the mouse button down to see the difference.

        Show
        Oleg Oleg [X] (Inactive) added a comment - I tested the patch and it does change underlining behavior in firefox 3.5. Without the patch, links are normally not underlined, when hovered they get underlined and when clicked stay underlined. With the patch links are normally still not underlined, when hovered they get underlined but when clicked they become not underlined again. You need to click a link and hold the mouse button down to see the difference.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Prosilver is also affected. This patch is for prosilver only. It changes behavior too, for example profile links in user posts stop being underlined when active.

        Since most styles derived from prosilver/subsilver copy their stylesheets, I imagine most styles are affected too. E.g. maxthon copies prosilver's stylesheet and wrong sequencing of anchor selectors.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Prosilver is also affected. This patch is for prosilver only. It changes behavior too, for example profile links in user posts stop being underlined when active. Since most styles derived from prosilver/subsilver copy their stylesheets, I imagine most styles are affected too. E.g. maxthon copies prosilver's stylesheet and wrong sequencing of anchor selectors.
        Hide
        AdamR Adam Reyher added a comment -

        While a very minor issue, it should be fixed. The proposed patch looks good.

        Show
        AdamR Adam Reyher added a comment - While a very minor issue, it should be fixed. The proposed patch looks good.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            schnorrer42 schnorrer42
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development