Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9158

viewforum/viewtopic pages unnecessarily duplicated with start=0

    Details

      Description

      If you go for example here:

      http://www.phpbb.com/community/viewforum.php?f=47

      you will notice that "General" heading is hyperlinked to

      http://www.phpbb.com/community/viewforum.php?f=47&start=0

      Similar behavior exists in viewtopic, heading of the topic gets start=0 added to its url.

      "start=0" is unnecessary and results in two pages being indexed by search engines for every actual forum or topic on a forum.

      I found out about this through google webmaster tools. In html suggestions I was told that I have pages with duplicate titles. Sure enough, since the pages are identical their titles are as well.

      Attached patch checks whether $start is equal to zero, and if so, does not append start=$start to viewforum/viewtopic urls.

      Technically several other pages have this behavior too, e.g. viewonline and mcp. But since they are unlikely to be usefully indexed I did not bother changing them. On my site I have robots.txt prohibiting viewonline and mcp access, among other things.

      1. start-seo.diff
        6 kB
        Oleg [X]
      2. start-seo-2.diff
        0.6 kB
        Oleg [X]

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Another location where this change should be made is in topic pagination. If topic has multiple pages, link to the first page on viewforum unnecessarily appends start=0 to the url.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Another location where this change should be made is in topic pagination. If topic has multiple pages, link to the first page on viewforum unnecessarily appends start=0 to the url.
        Hide
        ToonArmy Chris Smith added a comment -

        http://github.com/cs278/phpbb3/compare/bug/59465

        Thing is this is only the tip of the iceberg.

        Show
        ToonArmy Chris Smith added a comment - http://github.com/cs278/phpbb3/compare/bug/59465 Thing is this is only the tip of the iceberg.
        Hide
        bantu Andreas Fischer added a comment -

        I'm for doing this.

        Show
        bantu Andreas Fischer added a comment - I'm for doing this.
        Hide
        ToonArmy Chris Smith added a comment -

        Testing...

        Show
        ToonArmy Chris Smith added a comment - Testing...

          People

          • Assignee:
            ToonArmy Chris Smith
            Reporter:
            Oleg Oleg [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development