Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9095

Misleading setting text for CAPTCHA

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.8-RC1
    • Component/s: ACP
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      If you choose to use, say Q&A CAPTCHA, it will not work unless you enable a setting which says:

      Enable visual confirmation for registrations:
      Requires new users to enter a random code matching an image to help prevent mass registrations.

      (This setting appears in two places. See below.)

      Since there is no image nor any "random code" in the Q&A CAPTCHA, that text should read something like:

      Enable CAPTCHA module for registrations:
      Requires new users to complete the CAPTCHA module you select to help prevent mass registrations.

      In a related matter, there seems to be no need to have the above setting in two places, one in User registration settings and one in CAPTCHA module settings.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment - - edited

          What I was thinking about would be, to make the captcha-plugins return the string from there language-file. If none is specified, we fall back and use our current ones.

          Or we load the language-file of the active plug-in if one specified and tell the authors to overwrite the strings in there files if that's needed.

          Bugs that could be solved with this behaviour:
          PHPBB3-9095
          PHPBB3-9101
          PHPBB3-9641
          PHPBB3-9752
          PHPBB3-9786

          Show
          nickvergessen Joas Schilling added a comment - - edited What I was thinking about would be, to make the captcha-plugins return the string from there language-file. If none is specified, we fall back and use our current ones. Or we load the language-file of the active plug-in if one specified and tell the authors to overwrite the strings in there files if that's needed. Bugs that could be solved with this behaviour: PHPBB3-9095 PHPBB3-9101 PHPBB3-9641 PHPBB3-9752 PHPBB3-9786
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          I think the KISS method is better, remember CAPTCHA stands for Completely Automated Public Turing test to tell Computers and Humans Apart, so it doesn't matter if the CAPTCHA plugin used is a GD image, reCAPTCHA, Q&A or a Math equation, it is still nothing more than a CAPTCHA that has to be solved and should be referred to as generically as possible wherever possible.

          FYI...9641 is a duplicate of 9095 and should have been closed as such
          9786 is a duplicate of both 9095 & 9752, also should have been closed

          Show
          narqelion narqelion [X] (Inactive) added a comment - I think the KISS method is better, remember CAPTCHA stands for Completely Automated Public Turing test to tell Computers and Humans Apart, so it doesn't matter if the CAPTCHA plugin used is a GD image, reCAPTCHA, Q&A or a Math equation, it is still nothing more than a CAPTCHA that has to be solved and should be referred to as generically as possible wherever possible. FYI...9641 is a duplicate of 9095 and should have been closed as such 9786 is a duplicate of both 9095 & 9752, also should have been closed
          Hide
          bantu Andreas Fischer added a comment -

          Sure it would technically make sense to just use the term "CAPTCHA". The majority of people however probably do not know what "CAPTCHA" stands for.

          Show
          bantu Andreas Fischer added a comment - Sure it would technically make sense to just use the term "CAPTCHA". The majority of people however probably do not know what "CAPTCHA" stands for.
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          The majority of people however probably do not know what "CAPTCHA" stands for.

          The majority of people don't need to know what the acronym stands for, I merely pointed it out to remind you (the dev team) that a CAPTCHA is nothing more than an automated test, it is not just an image or a question & answer, it really can be any automated test that is designed to stop automated registrations/posting so you should not get specific with the language and not use words like image or question or any specific plugin language where the generic would suffice. You have the module named 'CAPTCHA module settings' so you obviously aren't too worried they don't know what the letters stand for. Take a look at the patch and you will see the language is now simpler, accurate and consistent. The existing language is all over the place and you are using multiple terms to refer to the exact same function, i.e. You are in the CAPTCHA module but you used Visual Confirmation when referring to a CAPTCHA, but only in certain field descriptors. The terminology was terribly inconsistent. I've fixed all inconsistent terminology and removed plugin specific language from the 'General Options' where it is not necessary or applicable. Take a look at the existing language here:
          http://www.dilligaff.org/images/old_acp_captchalang.jpg
          and then the module with the patch applied:
          http://www.dilligaff.org/images/new_acp_captchalang.png

          Show
          narqelion narqelion [X] (Inactive) added a comment - The majority of people however probably do not know what "CAPTCHA" stands for. The majority of people don't need to know what the acronym stands for, I merely pointed it out to remind you (the dev team) that a CAPTCHA is nothing more than an automated test, it is not just an image or a question & answer, it really can be any automated test that is designed to stop automated registrations/posting so you should not get specific with the language and not use words like image or question or any specific plugin language where the generic would suffice. You have the module named 'CAPTCHA module settings' so you obviously aren't too worried they don't know what the letters stand for. Take a look at the patch and you will see the language is now simpler, accurate and consistent. The existing language is all over the place and you are using multiple terms to refer to the exact same function, i.e. You are in the CAPTCHA module but you used Visual Confirmation when referring to a CAPTCHA, but only in certain field descriptors. The terminology was terribly inconsistent. I've fixed all inconsistent terminology and removed plugin specific language from the 'General Options' where it is not necessary or applicable. Take a look at the existing language here: http://www.dilligaff.org/images/old_acp_captchalang.jpg and then the module with the patch applied: http://www.dilligaff.org/images/new_acp_captchalang.png
          Hide
          narqelion narqelion [X] (Inactive) added a comment -

          Updated patch to fix additional language variable in the same file. 'ACP_VC_SETTINGS_EXPLAIN' was not reflecting that the CAPTCHA functionality has long since expanded beyond just the registration form.

          Show
          narqelion narqelion [X] (Inactive) added a comment - Updated patch to fix additional language variable in the same file. 'ACP_VC_SETTINGS_EXPLAIN' was not reflecting that the CAPTCHA functionality has long since expanded beyond just the registration form.

            People

            • Assignee:
              naderman Nils Adermann
              Reporter:
              stevemaury stevemaury
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development