Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9088

Add missing semicolons in js files

          Details

          • Type: Improvement
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.0.6
          • Fix Version/s: 3.0.8-RC1
          • Component/s: Styles
          • Labels:
            None

            Description

            Some lines in several js files are missing terminating semicolons. This could pose a problem if someone were to minify these files.

            Attached patch adds missing semicolons found by jslint.

              Issue Links

              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-9844 Two semicolons missing at the end of adm/style/editor.js

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-9845 Two semicolons missing at the end of styles/subsilver2/template/editor.js

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-9846 More semicolons missing at the end of phpBB/styles/prosilver/template/editor.js

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                bantu Andreas Fischer added a comment -

                Your report is missing the patch.

                Show
                bantu Andreas Fischer added a comment - Your report is missing the patch.
                Hide
                Permalink
                Oleg Oleg [X] (Inactive) added a comment -

                Yes indeed, here it is hopefully.

                Or it is definitely here

                Show
                Oleg Oleg [X] (Inactive) added a comment - Yes indeed, here it is hopefully. Or it is definitely here
                Hide
                Permalink
                bantu Andreas Fischer added a comment -

                Hmm, this could be an issue on our side.

                Show
                bantu Andreas Fischer added a comment - Hmm, this could be an issue on our side.
                Hide
                Permalink
                bantu Andreas Fischer added a comment -

                Fine with me, good patch.

                Show
                bantu Andreas Fischer added a comment - Fine with me, good patch.

                  People

                  • Assignee:
                    bantu Andreas Fischer
                    Reporter:
                    Oleg Oleg [X] (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development