Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9068

Grammatical Error under Load Settings

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.8-RC1
    • Component/s: ACP
    • Labels:
      None

      Description

      "Enable topic marking for guests:
      Stores read/unread status information for guests. If disabled posts are always read for guests."

      Should say:

      "Enable topic marking for guests:
      Stores read/unread status information for guests. If disabled, posts are always read for guests."

      Note the comma after "If disabled".

        Activity

        Hide
        nick.anderegg nick.anderegg added a comment -

        It was hard not to laugh while I was writing a patch for this one.

        The grammar is nice and fixed in my patch...

        Show
        nick.anderegg nick.anderegg added a comment - It was hard not to laugh while I was writing a patch for this one. The grammar is nice and fixed in my patch...
        Hide
        doowbert doowbert added a comment -

        I had to double take a few times when reading the statement. It seemed like there was such thing as a disabled guest.

        Show
        doowbert doowbert added a comment - I had to double take a few times when reading the statement. It seemed like there was such thing as a disabled guest.
        Hide
        nick.anderegg nick.anderegg added a comment -

        I think that was the easiest "bug" fix in the history of phpBB.

        Show
        nick.anderegg nick.anderegg added a comment - I think that was the easiest "bug" fix in the history of phpBB.
        Hide
        bantu Andreas Fischer added a comment -

        There have been similar fixes way back in time. :-P

        Show
        bantu Andreas Fischer added a comment - There have been similar fixes way back in time. :-P
        Hide
        bantu Andreas Fischer added a comment -

        Submitting revised patch. Changed author of commit to original patch author, changed [bug] to [ticket] as per http://wiki.phpbb.com/display/DEV/Git.

        Sent a PM to the user asking for an email address to be used in the commit.

        Show
        bantu Andreas Fischer added a comment - Submitting revised patch. Changed author of commit to original patch author, changed [bug] to [ticket] as per http://wiki.phpbb.com/display/DEV/Git . Sent a PM to the user asking for an email address to be used in the commit.
        Hide
        bantu Andreas Fischer added a comment -

        Author replied with real name and email address.

        Show
        bantu Andreas Fischer added a comment - Author replied with real name and email address.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            doowbert doowbert
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development