Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.10-RC1
    • Component/s: Installation system
    • Labels:
      None
    • Environment:
      PHP Environment: 5.3.1
      Database: MySQL 5.0.22

      Description

      During installation, when setting a table prefix, disallowed conventions (i.e. the use of dashes) are permitted to be submitted. This causes an error that forces the user to restart installation of phpBB.

        Issue Links

          Activity

          Hide
          ckwalsh Cullen Walsh [X] (Inactive) added a comment -

          I'm not sure how much of a problem this really is. Sure, invalid names are allowed, but the default is definitely a valid name, and (hopefully) anyone who changes the value knows what they are doing.

          Additionally, this can't break a board; the worst it can do is slow someone down a bit when installing.

          It definitely looks like a bug, but perhaps one not worth dealing with

          Show
          ckwalsh Cullen Walsh [X] (Inactive) added a comment - I'm not sure how much of a problem this really is. Sure, invalid names are allowed, but the default is definitely a valid name, and (hopefully) anyone who changes the value knows what they are doing. Additionally, this can't break a board; the worst it can do is slow someone down a bit when installing. It definitely looks like a bug, but perhaps one not worth dealing with
          Hide
          rxu Ruslan Uzdenov added a comment -

          Dash is not a prohibited character for tables naming (in MySQL at least).
          But we could try to validate prefix value in according to the common object names convention (see the manual for MySQL5+ or MySQL3.23+ for the reference).

          Show
          rxu Ruslan Uzdenov added a comment - Dash is not a prohibited character for tables naming (in MySQL at least). But we could try to validate prefix value in according to the common object names convention (see the manual for MySQL5+ or MySQL3.23+ for the reference).
          Hide
          nick.anderegg nick.anderegg added a comment -

          It's more of a convenience thing. I think maybe I'll whip up a patch for it.

          Show
          nick.anderegg nick.anderegg added a comment - It's more of a convenience thing. I think maybe I'll whip up a patch for it.
          Hide
          stevemaury stevemaury added a comment -

          Are you going to check the validity of the prefix for ALL of the allowed database types?

          Show
          stevemaury stevemaury added a comment - Are you going to check the validity of the prefix for ALL of the allowed database types?
          Hide
          nickvergessen Joas Schilling added a comment -

          > The prefix must start with an alphanumeric character, only contain alphanumeric characters and numbers and end with an underscores.

          Show
          nickvergessen Joas Schilling added a comment - > The prefix must start with an alphanumeric character, only contain alphanumeric characters and numbers and end with an underscores.
          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          I believe "a" is a very valid table prefix. The trailing underscore requirement should I think be deleted.

          And underscores are also very legitimate inside the table prefix. I think /w+$/ should be sufficient, or maybe /[a-zA-Z_]\w*$/ if \w includes digits.

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited I believe "a" is a very valid table prefix. The trailing underscore requirement should I think be deleted. And underscores are also very legitimate inside the table prefix. I think / w+$/ should be sufficient, or maybe / [a-zA-Z_] \w*$/ if \w includes digits.
          Hide
          bantu Andreas Fischer added a comment -

          I agree, the trailing underscore rule does not make much sense.

          Show
          bantu Andreas Fischer added a comment - I agree, the trailing underscore rule does not make much sense.
          Hide
          nickvergessen Joas Schilling added a comment -

          i think you dont really need underscores inside of the prefix aswell as it should not hurt if it ends with one

          but well, if you agree that it should be optional, i can do that.

          Show
          nickvergessen Joas Schilling added a comment - i think you dont really need underscores inside of the prefix aswell as it should not hurt if it ends with one but well, if you agree that it should be optional, i can do that.
          Hide
          nickvergessen Joas Schilling added a comment -

          Changed it to this behaviour now:

          The prefix must start with an alphanumeric character and must only contain alphanumeric characters, numbers and underscores.

          Show
          nickvergessen Joas Schilling added a comment - Changed it to this behaviour now: The prefix must start with an alphanumeric character and must only contain alphanumeric characters, numbers and underscores.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nick.anderegg nick.anderegg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development