Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9012

Retain original topic title in shadow topic when moving a topic and editing the title.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Posting
    • Labels:
      None

      Description

      If a topic's title is changed after it is moved (with shadow topic), the newly created topic shadow's subject remains the same, which appears in places such as the MCP. This can be confusing because of the discrepancy compared to viewtopic when a moderator wishes to remove a shadow topic.

      When updating the topic (only when the subject is changed), topic_id needs to be compared against topic_moved_id as well.

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Not so sure if it is supposed to be updated.

        Show
        bantu Andreas Fischer added a comment - Not so sure if it is supposed to be updated.
        Hide
        Kellanved Kellanved [X] (Inactive) added a comment -

        No, clearly not. The shadow topic is there to allow users to find a moved topic. If the topic was renamed, that is an extra reason to keep the shadow topic with the original name.

        Show
        Kellanved Kellanved [X] (Inactive) added a comment - No, clearly not. The shadow topic is there to allow users to find a moved topic. If the topic was renamed, that is an extra reason to keep the shadow topic with the original name.
        Hide
        ToonArmy Chris Smith added a comment -

        Agreed.

        Show
        ToonArmy Chris Smith added a comment - Agreed.
        Hide
        AdamR Adam Reyher added a comment -

        When you edit the actual topic in the new forum, the shadow topic name does, in fact, change in the original forum viewforum as well. It does not, however, change in the MCP.

        My point is not necessarily the actual changing of the topic name, but rather the discrepancy between viewforum and the MCP.

        • Adam
        Show
        AdamR Adam Reyher added a comment - When you edit the actual topic in the new forum, the shadow topic name does, in fact, change in the original forum viewforum as well. It does not, however, change in the MCP. My point is not necessarily the actual changing of the topic name, but rather the discrepancy between viewforum and the MCP. Adam
        Hide
        AdamR Adam Reyher added a comment - - edited

        Submitted proposed patch. Based on comments, viewforum will now show the old topic title in the original forum. The same topic title now appears in viewforum and the MCP.

        Show
        AdamR Adam Reyher added a comment - - edited Submitted proposed patch. Based on comments, viewforum will now show the old topic title in the original forum. The same topic title now appears in viewforum and the MCP.
        Hide
        bantu Andreas Fischer added a comment -

        Adjusted commit message to follow http://wiki.phpbb.com/display/DEV/Git.

        Show
        bantu Andreas Fischer added a comment - Adjusted commit message to follow http://wiki.phpbb.com/display/DEV/Git .

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            AdamR Adam Reyher
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development