Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8935

able to set minimal avatar size larger than maximum

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.8-RC1
    • Component/s: ACP
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      It's possible to set the minimal avatar size larger than the maximum..
      Which gives a somewhat weird error when trying to add an avatar

      Warning

      The submitted avatar is 176 pixels wide and 144 pixels high. Avatars must be at least 150 pixels wide and 150 pixels high, but no larger than 90 pixels wide and 90 pixels high.

      Perhaps a small check might be in order to prevent unaware and still sleepy admins for setting stuff like this...

        Issue Links

          Activity

          Hide
          ToonArmy Chris Smith added a comment -

          Fairly minor priority on this a generic solution is here: http://phpbb.cs278.org/patches/bug-55015.diff

          Show
          ToonArmy Chris Smith added a comment - Fairly minor priority on this a generic solution is here: http://phpbb.cs278.org/patches/bug-55015.diff
          Show
          ToonArmy Chris Smith added a comment - http://github.com/cs278/phpbb3/compare/bug/55015
          Hide
          igorw Igor Wiedler [X] (Inactive) added a comment -

          Please add a comment so that it's clear what is going on. One thing I noticed when testing it was the duplicate (I set min to 150x150 and min to 20x20):

          > The provided value for the setting “Maximum avatar dimensions” is too low. The minimum acceptable value is 150.
          > The provided value for the setting “Maximum avatar dimensions” is too low. The minimum acceptable value is 150.

          Happens because both use the same $config_definition['lang'], 'MAX_AVATAR_SIZE'. Kind of ugly but shouldn't happen in the first place. Changing/adding language vars just for this may not be worth it, but feel free to do so.

          Show
          igorw Igor Wiedler [X] (Inactive) added a comment - Please add a comment so that it's clear what is going on. One thing I noticed when testing it was the duplicate (I set min to 150x150 and min to 20x20): > The provided value for the setting “Maximum avatar dimensions” is too low. The minimum acceptable value is 150. > The provided value for the setting “Maximum avatar dimensions” is too low. The minimum acceptable value is 150. Happens because both use the same $config_definition ['lang'] , 'MAX_AVATAR_SIZE'. Kind of ugly but shouldn't happen in the first place. Changing/adding language vars just for this may not be worth it, but feel free to do so.
          Hide
          ToonArmy Chris Smith added a comment -

          Oh right I see because they use the same configuration value for the X and Y, tbh I think I'll just leave this as is.

          Show
          ToonArmy Chris Smith added a comment - Oh right I see because they use the same configuration value for the X and Y, tbh I think I'll just leave this as is.
          Hide
          unknown bliss unknown bliss added a comment -

          However, still not very good usability.
          Warning

          The provided value for the setting "Maximum avatar dimensions" is too low. The minimum acceptable value is 150.
          The provided value for the setting "Maximum avatar dimensions" is too low. The minimum acceptable value is 150.

          Could be changed to:

          Warning

          The provided value for the setting "Maximum avatar dimensions height" is too low. The minimum acceptable value is 150.
          The provided value for the setting "Maximum avatar dimensions width" is too low. The minimum acceptable value is 150.

          But that is for another ticket.

          Show
          unknown bliss unknown bliss added a comment - However, still not very good usability. Warning The provided value for the setting "Maximum avatar dimensions" is too low. The minimum acceptable value is 150. The provided value for the setting "Maximum avatar dimensions" is too low. The minimum acceptable value is 150. Could be changed to: Warning The provided value for the setting "Maximum avatar dimensions height" is too low. The minimum acceptable value is 150. The provided value for the setting "Maximum avatar dimensions width" is too low. The minimum acceptable value is 150. But that is for another ticket.

            People

            • Assignee:
              igorw Igor Wiedler [X] (Inactive)
              Reporter:
              Rotsblok Rikkert Westa [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development