Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8924

spelling in admin_welcome_inactive.txt

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Language pack
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      Very minor issue, but I thought I'd point it out...

      in "language/en/email/admin_welcome_inactive.txt" there is a typo. The end of line 13 reads:

      Another email will be sent when this had occured.

      It should read:

      Another email will be sent when this has occurred.

        Activity

        Hide
        narqelion narqelion [X] (Inactive) added a comment -

        The typo in the language file exists, and it does not match the same language used in user_activate_inactive.txt which is correct grammar:

        You will receive another notification when this has occurred.

        The "had" in admin_welcome_inactive.txt is using the wrong tense. Using past tense to reference an action that has not yet occurred is incorrect, even in the UK I believe.

        Show
        narqelion narqelion [X] (Inactive) added a comment - The typo in the language file exists, and it does not match the same language used in user_activate_inactive.txt which is correct grammar: You will receive another notification when this has occurred. The "had" in admin_welcome_inactive.txt is using the wrong tense. Using past tense to reference an action that has not yet occurred is incorrect, even in the UK I believe.
        Hide
        RMcGirr83 Rich McGirr added a comment -

        occured is spelled with two r's, as in

        occurred

        Show
        RMcGirr83 Rich McGirr added a comment - occured is spelled with two r's, as in occurred
        Hide
        naderman Nils Adermann added a comment -

        This bug report is entirely valid. You even agree with the reporter why are you marking it as possibly invalid?

        You should report that the fix failed to correct the spelling of occurred. The severity is not relating to the fix but to the bug report itself.

        Show
        naderman Nils Adermann added a comment - This bug report is entirely valid. You even agree with the reporter why are you marking it as possibly invalid? You should report that the fix failed to correct the spelling of occurred. The severity is not relating to the fix but to the bug report itself.
        Hide
        RMcGirr83 Rich McGirr added a comment -

        My bad...got confused a moment.

        Show
        RMcGirr83 Rich McGirr added a comment - My bad...got confused a moment.
        Hide
        naderman Nils Adermann added a comment -

        I will change this bug back to Reviewed so we can fix the double r in 3.0.8 or the next RC if there is something critical that forces us to release one. Certainly not worth having another RC for

        Show
        naderman Nils Adermann added a comment - I will change this bug back to Reviewed so we can fix the double r in 3.0.8 or the next RC if there is something critical that forces us to release one. Certainly not worth having another RC for
        Hide
        ToonArmy Chris Smith added a comment -

        What I just read the comments, wtf. I'll leave this as fixed, but somehow I screwed this up. xD

        Show
        ToonArmy Chris Smith added a comment - What I just read the comments, wtf. I'll leave this as fixed, but somehow I screwed this up. xD
        Hide
        ToonArmy Chris Smith added a comment -

        Oh right okay the reporter reported it, by typo he assumed he meant just one and missed the 2nd one. sigh

        Show
        ToonArmy Chris Smith added a comment - Oh right okay the reporter reported it, by typo he assumed he meant just one and missed the 2nd one. sigh
        Hide
        narqelion narqelion [X] (Inactive) added a comment -

        For those of you who care about traceability....

        The SVN commit happened here: (March 7,2010)
        http://code.phpbb.com/projects/phpbb/repository/revisions/10566

        The GIT (useless for non-GIT users)merge happened here (March 2, 2010):
        http://github.com/phpbb/phpbb3/commit/2f6c8a0164e08a66505bf322781b4ebce488e3bc

        Show
        narqelion narqelion [X] (Inactive) added a comment - For those of you who care about traceability.... The SVN commit happened here: (March 7,2010) http://code.phpbb.com/projects/phpbb/repository/revisions/10566 The GIT (useless for non-GIT users)merge happened here (March 2, 2010): http://github.com/phpbb/phpbb3/commit/2f6c8a0164e08a66505bf322781b4ebce488e3bc

          People

          • Assignee:
            ToonArmy Chris Smith
            Reporter:
            Drakkim Drakkim
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development