Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8894

JavaScript error and visible quote button on topic review if BBCodes disallowed

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Posting
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      I disabled BBCodes for guests and post message as guest, see JavaScript error:

      syntax error:
      bbcodeEnabled = ;\n

      The bad code is:

      <div id="topicreview">

      <script type="text/javascript">
      // <![CDATA[
      bbcodeEnabled = ;
      // ]]>
      </script>

      Should be:

      <div id="topicreview">

      <script type="text/javascript">
      // <![CDATA[
      var bbcodeEnabled = 0;
      // ]]>
      </script>

        Activity

        Hide
        Eelke Eelke Blok [X] (Inactive) added a comment -

        Which style/template is this?

        Show
        Eelke Eelke Blok [X] (Inactive) added a comment - Which style/template is this?
        Hide
        nickvergessen Joas Schilling added a comment -

        posting_topic_review.html

        Show
        nickvergessen Joas Schilling added a comment - posting_topic_review.html
        Hide
        Dionisiy Dionisiy added a comment -

        prosilver

        Show
        Dionisiy Dionisiy added a comment - prosilver
        Hide
        leviatan21 leviatan21 [X] (Inactive) added a comment -

        Related to [bug:1aohvk5k]53545[/bug:1aohvk5k]

        Show
        leviatan21 leviatan21 [X] (Inactive) added a comment - Related to [bug:1aohvk5k] 53545 [/bug:1aohvk5k]
        Hide
        leviatan21 leviatan21 [X] (Inactive) added a comment -

        the Fix URL: is wrong

        Show
        leviatan21 leviatan21 [X] (Inactive) added a comment - the Fix URL: is wrong
        Hide
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

        The branch was removed from nickvergessen's git repository after it was merged into the phpbb3 repository. The fix URL was right but it no longer exists.

        GitHub doesn't handle repositories with dozens of branches well, so branches need to be pruned every once in a while, and the branch was nearly 4 months old.

        Show
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment - The branch was removed from nickvergessen's git repository after it was merged into the phpbb3 repository. The fix URL was right but it no longer exists. GitHub doesn't handle repositories with dozens of branches well, so branches need to be pruned every once in a while, and the branch was nearly 4 months old.
        Hide
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

        By the way, you can also view the change set from the "Builds" tab in the tracker.

        Show
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment - By the way, you can also view the change set from the "Builds" tab in the tracker.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            Dionisiy Dionisiy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development