Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8802

Wrong confirmation text when clicking "mark forums read" in a category

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.x, 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Language pack
    • Labels:
      None

      Description

      If you are viewing a category and click on the "Mark forums read" link, then you get a confirmation message saying "All forums have been marked read". This is incorrect because only the current category/forum and its subforums have been marked read. So the text should be changed to "$forumtitle and all subforums have been marked read".

        Activity

        Hide
        Eelke Eelke Blok [X] (Inactive) added a comment -

        Correct me if I'm wrong, but I think the "Mark forums read" link does not actually mark the topics in the current forum read, just the subforums in it. "Forums" in this case means: "All forums within the current context." I bet the same phrase is also used on the index, which may be why it is over-generic.

        I would like it a lot better if the link would indeed work the way you suggest.

        Show
        Eelke Eelke Blok [X] (Inactive) added a comment - Correct me if I'm wrong, but I think the "Mark forums read" link does not actually mark the topics in the current forum read, just the subforums in it. "Forums" in this case means: "All forums within the current context." I bet the same phrase is also used on the index, which may be why it is over-generic. I would like it a lot better if the link would indeed work the way you suggest.
        Hide
        asinshesq asinshesq added a comment -

        At the risk of complicating things, I think a user ought to have a choice to (a) mark the topics in the forum read but leave the subforums alone, (b) mark the subforums read but leave the unread topics in the forum unread or (c) both.

        I suppose that could be done by having a link for marking topics read and another link for marking subforums read, or by giving users a confirmation box when they clicks the mark read link that would allow them to specify among several options.

        [edit: I realized after I posted this that phpbb3 already gives the user a choice to mark subforums read or mark topics in the forum read - see my later comment below]

        Show
        asinshesq asinshesq added a comment - At the risk of complicating things, I think a user ought to have a choice to (a) mark the topics in the forum read but leave the subforums alone, (b) mark the subforums read but leave the unread topics in the forum unread or (c) both. I suppose that could be done by having a link for marking topics read and another link for marking subforums read, or by giving users a confirmation box when they clicks the mark read link that would allow them to specify among several options. [edit: I realized after I posted this that phpbb3 already gives the user a choice to mark subforums read or mark topics in the forum read - see my later comment below]
        Hide
        Pyramide Pyramide [X] (Inactive) added a comment -

        Eelke:

        Correct me if I'm wrong, but I think the "Mark forums read" link does not actually mark the topics in the current forum read, just the subforums in it

        I just tried it out and you're right (only tested it in a category-only forum before). So the confirmation message should instead say "All subforums of $forumtitle have been marked read" or something similiar.

        asinshesq:

        or by giving users a confirmation box when they clicks the mark read link that would allow them to specify among several options.

        I guess that would be too much for a bugfix. IMHO the feature itself can stay as it is - just the message should be corrected because it currently says all forums have been marked read, which is not the case.

        Show
        Pyramide Pyramide [X] (Inactive) added a comment - Eelke: Correct me if I'm wrong, but I think the "Mark forums read" link does not actually mark the topics in the current forum read, just the subforums in it I just tried it out and you're right (only tested it in a category-only forum before). So the confirmation message should instead say "All subforums of $forumtitle have been marked read" or something similiar. asinshesq: or by giving users a confirmation box when they clicks the mark read link that would allow them to specify among several options. I guess that would be too much for a bugfix. IMHO the feature itself can stay as it is - just the message should be corrected because it currently says all forums have been marked read, which is not the case.
        Hide
        asinshesq asinshesq added a comment -

        Actually, I'm wrong. When you are in a forum that has subforums, viewforum already gives you two links:

        • a link that appears over the subforums up top that allows you to 'mark forums read'
        • a link that appears over the topics in the current forum that allows you to 'mark topics read'

        So the functionality is fine. But I think the link for marking the forums read should probably read 'mark subforums read' (and it would also be useful to adjust the confirmation message to be a bit clearer).

        Show
        asinshesq asinshesq added a comment - Actually, I'm wrong. When you are in a forum that has subforums, viewforum already gives you two links: a link that appears over the subforums up top that allows you to 'mark forums read' a link that appears over the topics in the current forum that allows you to 'mark topics read' So the functionality is fine. But I think the link for marking the forums read should probably read 'mark subforums read' (and it would also be useful to adjust the confirmation message to be a bit clearer).
        Hide
        bantu Andreas Fischer added a comment -

        Subsilver2 is not changed, but IMO it's good to go.

        Show
        bantu Andreas Fischer added a comment - Subsilver2 is not changed, but IMO it's good to go.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            Pyramide Pyramide [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development