Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8785

PM recipients/bcc list looks bad

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.x, 3.0.12, 3.1.0-a3
    • Fix Version/s: 3.1.0-b1
    • Labels:
    • Environment:
      PHP Environment:
      Database:

      Description

      The PM to list looks pretty bad, not enough room to have multiple usernames put on a single line and yet they are anyways.

        Activity

        Hide
        narqelion narqelion [X] (Inactive) added a comment -

        Yes the use of column1 & column2 is not particularly appropriate for those two floating blocks. In my custom style I created two new classes to float the divs in that form giving the To: column 74% and the group list 24% but in essence the whole PM form could use a serious overhaul in the UI department so ...

        Show
        narqelion narqelion [X] (Inactive) added a comment - Yes the use of column1 & column2 is not particularly appropriate for those two floating blocks. In my custom style I created two new classes to float the divs in that form giving the To: column 74% and the group list 24% but in essence the whole PM form could use a serious overhaul in the UI department so ...
        Hide
        unknown bliss unknown bliss added a comment -

        Blocker?

        Show
        unknown bliss unknown bliss added a comment - Blocker?
        Hide
        AmigoJack AmigoJack added a comment - - edited

        (Sorry - attaching a file silently skips any written text as a comment which I typed before - and thanks to AJAX it's lost forever)

        No blocker, of course.

        In terms of prosilver it basically comes down to these 3 lines in /styles/prosilver/template/posting_editor.html:

        <!-- IF not to_recipient.S_FIRST_ROW and to_recipient.S_ROW_COUNT mod 2 eq 0 --></dd><dd><!-- ENDIF -->
        ...
        <!-- IF not bcc_recipient.S_FIRST_ROW and bcc_recipient.S_ROW_COUNT mod 2 eq 0 --></dd><dd><!-- ENDIF -->
        ...
        <!-- IF not to_recipient.S_FIRST_ROW and to_recipient.S_ROW_COUNT mod 2 eq 0 --></dd><dd><!-- ENDIF -->

        ...which starts a new row after each 2 recipients. After removing those the space is used more efficiently (see picture).

        However, the two-column approach has its right to exist: phpBB groups can have the setting "Group able to receive private messages". If at least one (visible) group has this setting, a listbox of these groups also appears on the right side, where you're able to select potential recipients (also see picture).

        Show
        AmigoJack AmigoJack added a comment - - edited (Sorry - attaching a file silently skips any written text as a comment which I typed before - and thanks to AJAX it's lost forever) No blocker, of course. In terms of prosilver it basically comes down to these 3 lines in /styles/prosilver/template/posting_editor.html : <!-- IF not to_recipient.S_FIRST_ROW and to_recipient.S_ROW_COUNT mod 2 eq 0 --></dd><dd><!-- ENDIF --> ... <!-- IF not bcc_recipient.S_FIRST_ROW and bcc_recipient.S_ROW_COUNT mod 2 eq 0 --></dd><dd><!-- ENDIF --> ... <!-- IF not to_recipient.S_FIRST_ROW and to_recipient.S_ROW_COUNT mod 2 eq 0 --></dd><dd><!-- ENDIF --> ...which starts a new row after each 2 recipients. After removing those the space is used more efficiently (see picture). However, the two-column approach has its right to exist: phpBB groups can have the setting "Group able to receive private messages". If at least one (visible) group has this setting, a listbox of these groups also appears on the right side, where you're able to select potential recipients (also see picture).
        Hide
        AmigoJack AmigoJack added a comment -

        No forced linebreak after 2 recipients (modified template with removed lines).

        Show
        AmigoJack AmigoJack added a comment - No forced linebreak after 2 recipients (modified template with removed lines).
        Hide
        Crizzo Crizzo added a comment -

        I made a patch, but based on "develop"(3.1) not on 3.0

        Show
        Crizzo Crizzo added a comment - I made a patch, but based on "develop"(3.1) not on 3.0

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            EXreaction EXreaction [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development