Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8641

Extra and missing comma in acp_board.php

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.5
    • Fix Version/s: 3.1.0-a1
    • Component/s: ACP
    • Labels:
      None
    • Environment:
      PHP Environment: 5.2.8
      Database: MySQL 5.1.30

      Description

      There are some extra commas in includes/acp/acp_board.php and also some commas are missing in last lines of some arrays. That missing commas can cause extra effort when you add a new legend. Also, fixing that would make comma missing arrays be consistant with the other ones in that file.

      I added a patch for this.

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Fixed line endings in supplied patch so that it would apply.

        Two lines appear to have been fixed already, and I found one additional case of a missing comma.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Fixed line endings in supplied patch so that it would apply. Two lines appear to have been fixed already, and I found one additional case of a missing comma.
        Hide
        naderman Nils Adermann added a comment -

        Question is, fix this in 3.0 for MOD authors, which has the risk of breaking a number of MODs, or wait until 3.1?

        Show
        naderman Nils Adermann added a comment - Question is, fix this in 3.0 for MOD authors, which has the risk of breaking a number of MODs, or wait until 3.1?
        Hide
        mtrs mtrs added a comment -

        Considering that, this bug report being reviewed after a year, it can wait until 3.1, because, it may break some mods and as well as breaking Find actions of some mod instal.xml files.

        Show
        mtrs mtrs added a comment - Considering that, this bug report being reviewed after a year, it can wait until 3.1, because, it may break some mods and as well as breaking Find actions of some mod instal.xml files.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Moved to develop, changed branch name to match current standards.

        Branch name in commit message and author info need to be adjusted.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Moved to develop, changed branch name to match current standards. Branch name in commit message and author info need to be adjusted.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            mtrs mtrs
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development