Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8309

Rename "Last visited" to "Last activity" on memberlist/viewprofile

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.1.0-b2
    • Component/s: Language pack
    • Labels:

      Description

      language/en/memberlist.php is have "Last visited" is mean error.

      'VISITED' => 'Last visited',

      This is not last visit, this is last activity.

      This is my easy referance:

      $last_visit = (!empty($data['session_time'])) ? $data['session_time'] : $data['user_lastvisit'];  

      If user is online; "last activity" = "session time", session time is change on every page change. If user is offline "last activity" = "last visit", because if session is finish, session time fill on last visit time.

      session.php

      // Update the last visit time$sql = 'UPDATE ' . USERS_TABLE . '    SET user_lastvisit = ' . (int) $this->data['session_time'] . '    WHERE user_id = ' . (int) $this->data['user_id'];$db->sql_query($sql);  

      Then;

      language/en/memberlist.php is :

      'LAST_ACTIVITY' => 'Last activity,

      Images

      index, true; this is last visited time

      !http://img25.imageshack.us/img25/4449/indexjzu.png

      ucp, false; this is last activity time

      !http://img25.imageshack.us/img25/5920/ucp.png

      view profile, false; this is last activity time

      !http://img149.imageshack.us/img149/7376/profilej.png

        Activity

        Hide
        Marshalrusty Yuriy Rusko added a comment -

        angelside, is there any practical reason to change this? Confusion, etc.?

        Show
        Marshalrusty Yuriy Rusko added a comment - angelside, is there any practical reason to change this? Confusion, etc.?
        Hide
        bantu Andreas Fischer added a comment - - edited

        To clearify: The suggestion is to rename "Last visited" to "Last activity" in viewprofile because the value is not always user_lastvisit as used for "Your last visit" on the index page. On viewprofile the session table is also queried to check whether the user in question has a current session. If that is the case, then session_time is used instead of user_lastvisit. (The fact that we do not update user_lastvisit on every page load implies "session_time > user_lastvisit" if the user has a row in the session table.)

        Show
        bantu Andreas Fischer added a comment - - edited To clearify: The suggestion is to rename "Last visited" to "Last activity" in viewprofile because the value is not always user_lastvisit as used for "Your last visit" on the index page. On viewprofile the session table is also queried to check whether the user in question has a current session. If that is the case, then session_time is used instead of user_lastvisit. (The fact that we do not update user_lastvisit on every page load implies "session_time > user_lastvisit" if the user has a row in the session table.)

          People

          • Assignee:
            dhruv.goel92 Dhruv Goel
            Reporter:
            angelside angelside [X] (Inactive)
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development