Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8173

Redundant BBCode helpline in JS

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.0.10-RC1
    • Component/s: Styles
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      Location: ACP - Users management - Edit signature

      In the template, there is this line:

      t: '{LA_BBCODE_T_HELP}',

      It does not get generated and is redundant in the place, no button uses a helpline with the key 't', neither a accesskey to this letter is assigned.

        Activity

        Hide
        callum95 callum95 added a comment -

        I've committed a fix to this to my repo, but github won't let me send a pull request

        Show
        callum95 callum95 added a comment - I've committed a fix to this to my repo, but github won't let me send a pull request
        Hide
        naderman Nils Adermann added a comment -

        Why are you using y instead of e for list elements?

        Show
        naderman Nils Adermann added a comment - Why are you using y instead of e for list elements?
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Are these accesskeys documented anywhere at all?

        Naderman: I guess it has to do with this: <a href="./ucp.php" title="User Control Panel" accesskey="e">User Control Panel</a>

        Also note that the accesskey for the list is already y, it's only the help strings that use e.

        (Prior to the patch alt-shift-e goes to ucp, alt-shift-y prints a [*].)

        Show
        Oleg Oleg [X] (Inactive) added a comment - Are these accesskeys documented anywhere at all? Naderman: I guess it has to do with this: <a href="./ucp.php" title="User Control Panel" accesskey="e">User Control Panel</a> Also note that the accesskey for the list is already y, it's only the help strings that use e. (Prior to the patch alt-shift-e goes to ucp, alt-shift-y prints a [*] .)

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            ameeck Vojtech Vondra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development