Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8138

Browser autocompleton fills wrong fields in ACP

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.0.9-RC1
    • Component/s: ACP
    • Labels:
      None
    • Environment:
      PHP Environment: 5.2.6
      Database: MySQl 5.0.68

      Description

      In the ACP, option Users -> Manage Users, when I click on a user name to display all it's info some fields contains the admin login and password.
      In the Manage User, fields "Confirm user email" and "new password" contains the admin username and password prefilled.

      I use the latest version of Firefox (3.0.6)

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        This is a Bug of Firefox

        Show
        nickvergessen Joas Schilling added a comment - This is a Bug of Firefox
        Hide
        Peter_Smith Pete Smith [X] (Inactive) added a comment -

        Yep, this is the Firefox autocompleting username/password fields if you've asked Firefox to remember your login, not phpBB.

        You can disable this (at least in FF and IE) by adding a autocomplete="off" attribute in the username/password tag, but this would break XHTML standards, since autocomplete is not a valid attribute.

        Show
        Peter_Smith Pete Smith [X] (Inactive) added a comment - Yep, this is the Firefox autocompleting username/password fields if you've asked Firefox to remember your login, not phpBB. You can disable this (at least in FF and IE) by adding a autocomplete="off" attribute in the username/password tag, but this would break XHTML standards, since autocomplete is not a valid attribute.
        Hide
        naderman Nils Adermann added a comment -

        This happens for forum image/password fields when editing or creating a forum too.

        Show
        naderman Nils Adermann added a comment - This happens for forum image/password fields when editing or creating a forum too.
        Hide
        bantu Andreas Fischer added a comment -

        You realise you're breaking XHTML? Just making sure ...

        Show
        bantu Andreas Fischer added a comment - You realise you're breaking XHTML? Just making sure ...
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        In this case it's for a good cause.

        If a user remembers their password on a board, and they are an admin, they have to constantly clear the password field in acp whenever they are adding or editing forums.

        Show
        Oleg Oleg [X] (Inactive) added a comment - In this case it's for a good cause. If a user remembers their password on a board, and they are an admin, they have to constantly clear the password field in acp whenever they are adding or editing forums.
        Hide
        bantu Andreas Fischer added a comment -

        The problem is where to draw the line. http://tracker.phpbb.com/browse/PHPBB3-9457 would be useful too, but has been reverted because of breaking XHTML.

        Show
        bantu Andreas Fischer added a comment - The problem is where to draw the line. http://tracker.phpbb.com/browse/PHPBB3-9457 would be useful too, but has been reverted because of breaking XHTML.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        In case of this particular ticket autocomplete=off may be put into a template variable so that it can be omitted by whoever wants to validate their styles.

        Show
        Oleg Oleg [X] (Inactive) added a comment - In case of this particular ticket autocomplete=off may be put into a template variable so that it can be omitted by whoever wants to validate their styles.
        Hide
        bantu Andreas Fischer added a comment -

        Oops. This breaks unit tests.

        1) phpbb_functions_acp_build_cfg_template_test::test_build_cfg_template_text with data set #1 (array('password', 20, 128), 'key_name', array('2'), 'config_key_name', array(), '<input id="key_name" type="password" size="20" maxlength="128" name="config[config_key_name]" value="2" />')
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -<input id="key_name" type="password" size="20" maxlength="128" name="config[config_key_name]" value="2" />
        +<input id="key_name" type="password" size="20" maxlength="128" name="config[config_key_name]" value="2" autocomplete="off" />
        

        Show
        bantu Andreas Fischer added a comment - Oops. This breaks unit tests. 1) phpbb_functions_acp_build_cfg_template_test::test_build_cfg_template_text with data set #1 (array('password', 20, 128), 'key_name', array('2'), 'config_key_name', array(), '<input id="key_name" type="password" size="20" maxlength="128" name="config[config_key_name]" value="2" />') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -<input id="key_name" type="password" size="20" maxlength="128" name="config[config_key_name]" value="2" /> +<input id="key_name" type="password" size="20" maxlength="128" name="config[config_key_name]" value="2" autocomplete="off" />

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            cd090580 cd090580
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development