Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8134

Scalability issue in check_ban() in session.php

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Duplicate
    • 3.0.4
    • 3.1.4-RC1
    • Sessions
    • None
    • PHP Environment:
      Database: MySQL(i) 5.0.32

    Description

      I recently found a scalability problem in here, where if the banlist is large (for example, the forum is using a ready-made list of known forum spammer IPs) the function would make an ambiguous query, which could include many thousands of result rows. This would cause slow execution time, and possible PHP memory limit exceptions and/or maximum execution time exceptions, not to mention high memory and processor usage in general.

      I have written a patch for the issue, but don't know what the right channel to go through to submit it is on phpBB.

      Attachments

        Issue Links

          Activity

            People

              nickvergessen Joas Schilling
              xolani xolani
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: